build 3.7.1 rpms #18184

pennpeng · 2018-01-19T10:06:36Z

[root@oc-3 origin]# make build-rpms-redistributable
hack/build-rpm-release.sh
[INFO] Building Origin release RPMs with tito...
Creating output directory: /tmp/tito
ERROR: Error running command: git config --get user.name

Status code: 256

Command output: 

WARNING: user.name in ~/.gitconfig not set.

ERROR: Error running command: git config --get user.email

Status code: 256

Command output: 

WARNING: user.email in ~/.gitconfig not set.

OS_GIT_MINOR::7+
OS_GIT_MAJOR::3
OS_GIT_VERSION::v3.7.1+ab0f056
OS_GIT_TREE_STATE::clean
OS_GIT_CATALOG_VERSION::v0.1.2
OS_GIT_COMMIT::ab0f056
Tagging new version of origin: 0.0.1 -> 3.7.1-1.0.ab0f056
Traceback (most recent call last):
  File "/usr/bin/tito", line 23, in <module>
    CLI().main(sys.argv[1:])
  File "/usr/lib/python2.7/site-packages/tito/cli.py", line 203, in main
    return module.main(argv)
  File "/usr/lib/python2.7/site-packages/tito/cli.py", line 671, in main
    return tagger.run(self.options)
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 114, in run
    self._tag_release()
  File "/home/origin/.tito/lib/origin/tagger/__init__.py", line 40, in _tag_release
    super(OriginTagger, self)._tag_release()
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 136, in _tag_release
    self._check_tag_does_not_exist(self._get_new_tag(new_version))
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 555, in _get_new_tag
    return self._get_tag_for_version(suffixed_version, release)
TypeError: _get_tag_for_version() takes exactly 2 arguments (3 given)
[ERROR] PID 2032: hack/build-rpm-release.sh:30: `tito tag --use-version="${OS_RPM_VERSION}" --use-release="${OS_RPM_RELEASE}" --no-auto-changelog --offline` exited with status 1.
[INFO] 		Stack Trace: 
[INFO] 		  1: hack/build-rpm-release.sh:30: `tito tag --use-version="${OS_RPM_VERSION}" --use-release="${OS_RPM_RELEASE}" --no-auto-changelog --offline`
[INFO]   Exiting with code 1.
[ERROR] hack/build-rpm-release.sh exited with code 1 after 00h 00m 06s
make: *** [build-rpms-redistributable] Error 1
[root@oc-3 origin]#

The text was updated successfully, but these errors were encountered:

php-coder · 2018-01-19T11:02:20Z

WARNING: user.name in ~/.gitconfig not set.

Look like you have to set user.name in the git configuration.

pennpeng · 2018-01-21T12:43:03Z

@php-coder that's WARNING， not the error

php-coder · 2018-01-21T12:44:31Z

Yes, but when it tries to get this value it fails:

ERROR: Error running command: git config --get user.email

pennpeng · 2018-01-21T12:47:11Z

@php-coder hi，i use this command build 3.9 alpha3 that's ok ， but 3.7.1 is not

php-coder · 2018-01-21T13:21:07Z

CC @stevekuznetsov

stevekuznetsov · 2018-01-22T16:35:29Z

Looks like you need a git environment with user name, etc.

pennpeng · 2018-01-23T08:02:53Z

@php-coder @stevekuznetsov look the real error. when i config git environment ,same error:

[root@oc-3 origin]# make build-rpms-redistributable
hack/build-rpm-release.sh
[INFO] Building Origin release RPMs with tito...
Creating output directory: /tmp/tito
OS_GIT_VERSION::v3.6.1+efb0d59-8
OS_GIT_MINOR::6+
OS_GIT_COMMIT::efb0d59
OS_GIT_MAJOR::3
OS_GIT_TREE_STATE::clean
Tagging new version of origin: 0.0.1 -> 3.6.1-1.8.efb0d59
Traceback (most recent call last):
  File "/usr/bin/tito", line 23, in <module>
    CLI().main(sys.argv[1:])
  File "/usr/lib/python2.7/site-packages/tito/cli.py", line 203, in main
    return module.main(argv)
  File "/usr/lib/python2.7/site-packages/tito/cli.py", line 671, in main
    return tagger.run(self.options)
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 114, in run
    self._tag_release()
  File "/home/origin/.tito/lib/origin/tagger/__init__.py", line 40, in _tag_release
    super(OriginTagger, self)._tag_release()
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 136, in _tag_release
    self._check_tag_does_not_exist(self._get_new_tag(new_version))
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 555, in _get_new_tag
    return self._get_tag_for_version(suffixed_version, release)
TypeError: _get_tag_for_version() takes exactly 2 arguments (3 given)
[ERROR] PID 12758: hack/build-rpm-release.sh:22: `tito tag --use-version="${OS_RPM_VERSION}" --use-release="${OS_RPM_RELEASE}" --no-auto-changelog --offline` exited with status 1.
[INFO] 		Stack Trace: 
[INFO] 		  1: hack/build-rpm-release.sh:22: `tito tag --use-version="${OS_RPM_VERSION}" --use-release="${OS_RPM_RELEASE}" --no-auto-changelog --offline`
[INFO]   Exiting with code 1.
make: *** [build-rpms-redistributable] Error 1
[root@oc-3 origin]#

stevekuznetsov · 2018-01-23T15:47:49Z

@dgoodwin does that stacktrace from tito ring any bells?

dgoodwin · 2018-01-23T15:50:25Z

It doesn't but that code saw some churn in the latest version and I've seen other issues around that which broke users and still need fixing. Is this with tito 0.6.11?

pennpeng · 2018-01-24T03:38:12Z

@dgoodwin
hi,

[root@oc-3 ~]# rpm -qa | grep tito
tito-0.6.11-1.el7.noarch

pennpeng · 2018-01-29T01:23:01Z

no one help me????

stevekuznetsov · 2018-01-29T16:44:46Z

@dgoodwin any thoughts here?

/unassign
/assign @dgoodwin

dgoodwin · 2018-01-29T17:20:18Z

Apologies I haven't had time yet to look and fix, it certainly looks like a bug in tito but I'm unclear why this is only surfacing here. Will try to find some time soon.

ibotty · 2018-02-03T18:45:39Z

Is that bug the reason why there are no 3.7.1 rpms in centos' paas repo yet?

DanyC97 · 2018-02-08T18:21:24Z

@ibotty i believe due to the issue which @dgoodwin said he will look into it ?

MansM · 2018-02-13T11:32:32Z

any news @dgoodwin?

dgoodwin · 2018-02-13T12:29:22Z

The issue is with the custom tagger in use by origin: https://github.com/openshift/origin/blob/master/.tito/lib/origin/tagger/__init__.py#L42 does not match the method signature for https://github.com/dgoodwin/tito/blob/master/src/tito/tagger/main.py#L570.

DanyC97 · 2018-02-15T21:15:11Z

@dgoodwin are you tackling the issue since it seems you know / are familiar with it or don't have the bandwidth ?

MansM · 2018-02-16T08:12:00Z

Weird that that tagger issue pops up now, the OS line over a year old and the tito line is over 10 months old

dgoodwin · 2018-02-16T12:50:46Z

@DanyC97 apologies I do not have the bandwidth, I tried to build origin while debugging but couldn't get it working offhand. For someone who is setup for origin building it should be a very quick Python fix, most likely just adding "release=None" to that method signature and you'll be good to go.

@MansM probably surfaced late because of delay in when it was released to Fedora/EPEL repos in December. Struggling to find time to maintain tito all around. :)

DanyC97 · 2018-02-21T13:49:52Z

sure, thanks @dgoodwin .
@stevekuznetsov done it already +1

With that said, who is the best person to tag so that it can push the rpms into the centOS repo ?

DanyC97 · 2018-02-23T09:05:34Z

@sdodson @michaelgugino anyone of you able to ping the person responsible with creating the rpms and who has access to publish them to centos repo?

thx for your help

sdodson · 2018-02-23T21:51:40Z

@arilivigni @tdawson Can we get 3.7.1 rpms built?

jameseck · 2018-02-25T11:30:06Z

+1 for these rpms to be built please

DanyC97 · 2018-03-06T06:23:00Z

@arilivigni @tdawson no chance to show some love to this issue ? everyone is been asking for the rpms for a very long time ....

tdawson · 2018-03-06T14:13:24Z

Sorry, we should have reported our progress on this.
This has been getting quite a bit of love, just not a final product.
Should be soon, hopefully within two days.

tdawson · 2018-03-06T14:18:43Z

Side note, team who is doing this on CentOS is completely volunteers now. Nobody is paid to do it.
Real Life is calling, and they will be stepping down (a) in a week and (b) in two months.
http://lists.openshift.redhat.com/openshift-archives/dev/2018-February/msg00015.html

tdawson · 2018-03-06T22:47:01Z

origin 3.7.1, and openshift ansible 3.7.35 are both available in the testing repository at
https://buildlogs.centos.org/centos/7/paas/x86_64/openshift-origin37/

We need some people to test these and make sure everything is ok. Once they have been tested, we will get them signed and in the released repositories.

DanyC97 · 2018-03-08T11:49:07Z

@tdawson thanks for the heads up with the announcement, i wasn't aware of that.

I'll speak internally and will try to get the ball rolling for testing origin 3.7.1
I might reach out to you privately if my current employer is willing for us to step up on taking the baton

gh1001 · 2018-03-12T21:31:54Z

I'm just wondering what people do for critical security patches such as the ones mentioned in https://access.redhat.com/errata/RHSA-2018:0475 ?

I found the PRs that fix the issues (kubernetes/kubernetes#60813, kubernetes/kubernetes#60814) but these are in K8 and I'm not seeing the origin repo release branches contain recent commits. However, given that the above paid redhat subscription enables users to download updated packages, I assume there's a way to build origin with patched versions of k8? https://github.com/openshift/origin/blob/master/HACKING.md#using-hackcherry-pick ?

liggitt · 2018-03-13T00:07:17Z

@gh1001 origin PRs are open at https://github.com/openshift/origin/pulls?utf8=%E2%9C%93&q=is%3Apr+CVE-2017-1002101 ... releases will be cut once merged

DanyC97 · 2018-04-19T11:22:11Z

@pennpeng can we close this ticket as the rpms are not available ?

sdodson · 2018-04-19T12:37:49Z

3.7.2 is now in the repo. http://mirror.centos.org/centos/7/paas/x86_64/openshift-origin37/

php-coder added the component/internal-tools label Jan 22, 2018

pweil- assigned stevekuznetsov Jan 24, 2018

pweil- added kind/question priority/P3 labels Jan 24, 2018

openshift-ci-robot assigned dgoodwin and unassigned stevekuznetsov Jan 29, 2018

DanyC97 mentioned this issue Feb 13, 2018

lack of 3.7.1 rpm's blocks containarized upgrade openshift/openshift-ansible#6788

Closed

stevekuznetsov mentioned this issue Feb 16, 2018

Update custom tito tagger for new version #18647

Merged

DanyC97 mentioned this issue Feb 21, 2018

Missing Centos PaaS RPM packages for openshift origin v3.7.1 #18679

Closed

nak3 mentioned this issue Apr 11, 2018

[3.7] Add restart single master handler for etcdv3 upgrade from embedded etcd openshift/openshift-ansible#7801

Merged

sdodson closed this as completed Apr 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build 3.7.1 rpms #18184

build 3.7.1 rpms #18184

pennpeng commented Jan 19, 2018

php-coder commented Jan 19, 2018

pennpeng commented Jan 21, 2018

php-coder commented Jan 21, 2018

pennpeng commented Jan 21, 2018

php-coder commented Jan 21, 2018

stevekuznetsov commented Jan 22, 2018

pennpeng commented Jan 23, 2018

stevekuznetsov commented Jan 23, 2018

dgoodwin commented Jan 23, 2018

pennpeng commented Jan 24, 2018

pennpeng commented Jan 29, 2018

stevekuznetsov commented Jan 29, 2018

dgoodwin commented Jan 29, 2018

ibotty commented Feb 3, 2018

DanyC97 commented Feb 8, 2018

MansM commented Feb 13, 2018

dgoodwin commented Feb 13, 2018

DanyC97 commented Feb 15, 2018

MansM commented Feb 16, 2018 •

edited

Loading

dgoodwin commented Feb 16, 2018

DanyC97 commented Feb 21, 2018

DanyC97 commented Feb 23, 2018

sdodson commented Feb 23, 2018

jameseck commented Feb 25, 2018

DanyC97 commented Mar 6, 2018

tdawson commented Mar 6, 2018

tdawson commented Mar 6, 2018

tdawson commented Mar 6, 2018

DanyC97 commented Mar 8, 2018

gh1001 commented Mar 12, 2018

liggitt commented Mar 13, 2018 •

edited

Loading

DanyC97 commented Apr 19, 2018

sdodson commented Apr 19, 2018

build 3.7.1 rpms #18184

build 3.7.1 rpms #18184

Comments

pennpeng commented Jan 19, 2018

php-coder commented Jan 19, 2018

pennpeng commented Jan 21, 2018

php-coder commented Jan 21, 2018

pennpeng commented Jan 21, 2018

php-coder commented Jan 21, 2018

stevekuznetsov commented Jan 22, 2018

pennpeng commented Jan 23, 2018

stevekuznetsov commented Jan 23, 2018

dgoodwin commented Jan 23, 2018

pennpeng commented Jan 24, 2018

pennpeng commented Jan 29, 2018

stevekuznetsov commented Jan 29, 2018

dgoodwin commented Jan 29, 2018

ibotty commented Feb 3, 2018

DanyC97 commented Feb 8, 2018

MansM commented Feb 13, 2018

dgoodwin commented Feb 13, 2018

DanyC97 commented Feb 15, 2018

MansM commented Feb 16, 2018 • edited Loading

dgoodwin commented Feb 16, 2018

DanyC97 commented Feb 21, 2018

DanyC97 commented Feb 23, 2018

sdodson commented Feb 23, 2018

jameseck commented Feb 25, 2018

DanyC97 commented Mar 6, 2018

tdawson commented Mar 6, 2018

tdawson commented Mar 6, 2018

tdawson commented Mar 6, 2018

DanyC97 commented Mar 8, 2018

gh1001 commented Mar 12, 2018

liggitt commented Mar 13, 2018 • edited Loading

DanyC97 commented Apr 19, 2018

sdodson commented Apr 19, 2018

MansM commented Feb 16, 2018 •

edited

Loading

liggitt commented Mar 13, 2018 •

edited

Loading