Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified files after building #209

Closed
cpmeadors opened this issue Aug 17, 2022 · 2 comments · Fixed by #211
Closed

Modified files after building #209

cpmeadors opened this issue Aug 17, 2022 · 2 comments · Fixed by #211

Comments

@cpmeadors
Copy link
Contributor

After running docker-build, bundle-build, catalog-build There are a number of modified files. Are these safe if they accidentally get checked in? Should they be getting updated? Should they be updated in the repo?

bundle.Dockerfile
config/crd/bases/kataconfiguration.openshift.io_kataconfigs.yaml
config/rbac/role.yaml
config/webhook/manifests.yaml
bundle/manifests/kataconfiguration.openshift.io_kataconfigs.yaml
bundle/metadata/annotations.yaml

@bpradipt
Copy link
Contributor

Files under config/ typically get updated if there are changes to the API, sdk, or when building your own operator image.
The changes due to API or sdk are core code related changes and hence needs to be tracked.

Files under bundle/ are generated from config/ on execution of make bundle. The reason for checking this is to get a repeatable build of the bundle and catalog when using the upstream code without regenerating the bundle. We can think about completely removing the bundle directory.

One option is to provide git instructions to not track the local changes if needed by the developer.

@cpmeadors
Copy link
Contributor Author

Based on the operator-sdk docs, "make generate" creates:

api/v1/zz_generated.deepcopy.go

"make manifests" creates:

config/crd/bases/kataconfiguration.openshift.io_kataconfigs.yaml
config/rbac/role.yaml
config/webhook/manifests.yaml

"make bundle" generates

bundle.Dockerfile
bundle/metadata/annotations.yaml
bundle

Why should any of these files be tracked? The files that define the generation of them are tracked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants