Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review code in cmd/sti/main.go#newCmdBuild to extract what might be useful to have in origin. #206

Closed
soltysh opened this issue May 29, 2015 · 2 comments
Assignees

Comments

@soltysh
Copy link
Member

soltysh commented May 29, 2015

Per this comment, we should review the code in cmd/sti/main.go#newCmdBuild and extract as much as we can from there into separate package that we'll be able to reduce the amount of duplication in code in S2I and origin.

@coreydaley
Copy link
Member

@bparees
The only code that I see in newCmdBuild that MIGHT be useful to factor out into something reusable is https://github.com/openshift/source-to-image/blob/master/pkg/cmd/cli/cmd/build.go#L100-L123

So, with that being said:

  • Do you see other code that would be useful?
  • Is it worth it?
  • Is this github issue still relevant?

@bparees
Copy link
Contributor

bparees commented Jan 12, 2018

not worth it.

@bparees bparees closed this as completed Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants