Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileAdapter() performance issues with large files #2394

Closed
jimmyDunne opened this issue Dec 5, 2018 · 4 comments
Closed

FileAdapter() performance issues with large files #2394

jimmyDunne opened this issue Dec 5, 2018 · 4 comments

Comments

@jimmyDunne
Copy link
Member

User report poor performance of the STOFileApater() when trying to read sto files that are very large (>100mb). These large sto files are generated from OpenSim simulations that are very long (~500 sec).
@jimmyDunne jimmyDunne changed the title FileAdapter() FileAdapter() performance issues with large files Dec 5, 2018
@tkuchida
Copy link
Member

tkuchida commented Dec 5, 2018

"Python" is tagged in the Forum post. Same issue in C++ or only via wrapping?

@jimmyDunne
Copy link
Member Author

I am not sure. I have emailed the user to get the files needed to recreate the large .sto file. Then I can test

@aseth1
Copy link
Member

aseth1 commented Dec 5, 2018

It is likely the same memory allocation/move issue we saw for C3DFileAdapter (#1698, #1730) because STOFileAdapter also appends a row one by one to the underlying matrix.

@carmichaelong carmichaelong mentioned this issue Dec 18, 2018
Merged
@aseth1
Copy link
Member

aseth1 commented Dec 20, 2018 •
edited
Loading

closed by #2399

@aseth1 aseth1 closed this as completed Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tkuchida @jimmyDunne @aseth1