Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setMemomryOwner from the public interface of OpenSim::ArrayPtrs #3275

Open
aymanhab opened this issue Aug 9, 2022 · 0 comments
Open

Comments

@aymanhab
Copy link
Member

aymanhab commented Aug 9, 2022

As explained in #3274 and as evident by the list of issues/PRs due to leaks or crashes due to the use of this flag, this is practically giving users a way to shoot themselves in the foot.
The proposal here is to:

  1. Remove the setMemoryOwner from the public interface.
  2. Make the code behave as setMemoryOwner is set to true when ownership is the desired behavior
  3. Move clients to a container of shared_ptrs when ownership is not the desired behavior (I don't think there're instances of the code where the flag changes during runtime anyway so the flag's correct settings is known on construction.
  4. Remove the flag altogether.
@aymanhab aymanhab changed the title Remove setMemomryOwner from the public interface of OpenSim::Array Remove setMemomryOwner from the public interface of OpenSim::ArrayPtrs Aug 9, 2022
@jenhicks jenhicks added this to the Future Release milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants