You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As explained in #3274 and as evident by the list of issues/PRs due to leaks or crashes due to the use of this flag, this is practically giving users a way to shoot themselves in the foot.
The proposal here is to:
Remove the setMemoryOwner from the public interface.
Make the code behave as setMemoryOwner is set to true when ownership is the desired behavior
Move clients to a container of shared_ptrs when ownership is not the desired behavior (I don't think there're instances of the code where the flag changes during runtime anyway so the flag's correct settings is known on construction.
Remove the flag altogether.
The text was updated successfully, but these errors were encountered:
aymanhab
changed the title
Remove setMemomryOwner from the public interface of OpenSim::Array
Remove setMemomryOwner from the public interface of OpenSim::ArrayPtrs
Aug 9, 2022
As explained in #3274 and as evident by the list of issues/PRs due to leaks or crashes due to the use of this flag, this is practically giving users a way to shoot themselves in the foot.
The proposal here is to:
The text was updated successfully, but these errors were encountered: