TRC file written by GUI cannot be read by TRCFileAdapter

[tkuchida]

Steps to reproduce

• File > Preview Experimental Data…
• Open walking2_markers.trc (extracted from walking2.c3d) and attached in this .zip file: walking2_markers.zip
• In Navigator, expand "ExperimentalData_0", right-click on "walking2_markers.trc", and select "Transform"
• Rotate by 90 degrees about X (arbitrary) and save as "transformed_walking2_markers.trc"
• Preview new "transformed_walking2_markers.trc" file in GUI --> works
• Attempt to read file in Python using TRCFileAdapter:

import opensim as osim
markers = osim.TRCFileAdapter.read('transformed_walking2_markers.trc')

Expected result

File can be read in the GUI and in Python

Actual result

Either both should work or both should fail. The GUI can read the file, which suggests to the user that the file has been correctly written. However, the file cannot be read from Python because the whitespace in the header is incorrect. Error message:

RuntimeError: std::exception in 'OpenSim::TimeSeriesTableVec3 OpenSim::TRCFileAdapter::read(std::string const &)': Error reading column Labels in file 'transformed_walking2_markers.trc'. Unexpected number of column labels. Expected = 46. Recieved = 44.
	Thrown at trcfileadapter.cpp:125 in extendRead().

Environment and GUI version

Public release of 4.0

[tkuchida]

@aymanhab See L409 and L410 here: spaces should be \t as elsewhere.

[aymanhab]

Perfect, now that you did the hard part and found it @tkuchida do you mind submitting a PR ;) or I can do it later. Thanks 👍

[tkuchida]

Unfortunately, I've never been able to build the GUI 😢 so I have no way of testing.

[aymanhab]

A build/artifact including the fix successfully opened the trc file from the scripting shell.

[aymanhab]

If somebody can verify fix in artifact that would be great. Use scripting shell easier than python environment

[jimmyDunne]

I downloaded and installed the latest GUI artifact on a Windows VM, performed the transform in the GUI, and use Python to read the transformed trc. It seemed to work without issue-- no exceptions or oddities. I think we should still test again when before doing the next minor release.

[aymanhab]

Any reason this is not closed @jimmyDunne