Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Train test split utility function #227

Closed
risenW opened this issue Jun 20, 2021 · 10 comments
Closed

Train test split utility function #227

risenW opened this issue Jun 20, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers no-issue-activity

Comments

@risenW
Copy link
Member

risenW commented Jun 20, 2021

We should be able to pass a dataset to a function called train_test_split and get back splits of training and testing data similar to the sklearn train_test_split function here.
.

@risenW risenW added enhancement New feature or request good first issue Good for newcomers labels Jun 20, 2021
@EteimZ
Copy link

EteimZ commented Jun 26, 2021

Hi @risenW, I would love to work on this issue.

@risenW
Copy link
Member Author

risenW commented Jun 26, 2021

Hi @risenW, I would love to work on this issue.

Cool, I'll assign you. if you have any questions or clarification, just ping me.

Also, this should be implemented in the processing folder here: https://github.com/opensource9ja/danfojs/tree/master/danfojs-node/src/preprocessing

You can also read our contributing guide/set up here: https://danfo.jsdata.org/contributing-guide

@EteimZ
Copy link

EteimZ commented Jun 26, 2021

Okay, Thanks a lot.

@EteimZ
Copy link

EteimZ commented Jul 3, 2021

Hi @risenW how can I bundle danfojs-browser version, is it by running:

yarn bundle

@risenW
Copy link
Member Author

risenW commented Jul 3, 2021

Hi @risenW how can I bundle danfojs-browser version, is it by running:

yarn bundle

Yes

@EteimZ
Copy link

EteimZ commented Jul 3, 2021

Thanks, if I want to run it locally do I place the bundle.js within <script> tags.

@risenW
Copy link
Member Author

risenW commented Jul 3, 2021

Thanks, if I want to run it locally do I place the bundle.js within <script> tags.

Yes 👍

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Stale issue message

@risenW
Copy link
Member Author

risenW commented Oct 3, 2021

@EteimZ Let’s move this feature to the new scikit.js lib we are building. See link here: https://github.com/opensource9ja/scikit.js

@risenW
Copy link
Member Author

risenW commented Jan 19, 2022

Closing this as no activity, and it has been implemented in https://github.com/opensource9ja/scikit.js

@risenW risenW closed this as completed Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants