Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header on the Jobs page is different from other pages #435

Open
nevfy-y opened this issue Feb 1, 2024 · 13 comments
Open

Header on the Jobs page is different from other pages #435

nevfy-y opened this issue Feb 1, 2024 · 13 comments
Assignees
Labels
bug An error or something is not working correctly content Writing and/or design of content good first issue Small tasks with clear documentation about how and in which place you need to fix things in. Jobs An issue related to the Job board repo https://github.com/opensourcedesign/jobs

Comments

@nevfy-y
Copy link

nevfy-y commented Feb 1, 2024

This doesn't seem intentional. I think the header should have remained the same on every page.

Goals page:
2024_02_02_02_27_AM

Jobs page:
2024_02_02_02_28_AM

@Erioldoesdesign
Copy link
Member

hey there @nevfy-y i don't think it's intentional - I think the main reason the jobs page header navigation doesn't get updated to match the 'rest' of the website is just because the page/index code 'on(?)' a different repo: https://github.com/opensourcedesign/jobs/blob/master/index.html

@Erioldoesdesign
Copy link
Member

If you'd like to open a pull request to fix this please go ahead - I think it'd be good for the nav header to match across the website 😄

@Erioldoesdesign Erioldoesdesign added bug An error or something is not working correctly content Writing and/or design of content Jobs An issue related to the Job board repo https://github.com/opensourcedesign/jobs good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Apr 2, 2024
@subz3r0o0
Copy link
Contributor

hi could i be assigned to fix this issue, thank you!

@Erioldoesdesign
Copy link
Member

hi could i be assigned to fix this issue, thank you!

Feel free to submit a PR - I'll assign you to this issue for 2 weeks and then check back in and un-assign if I do not see any comments or PR's :)

@subz3r0o0
Copy link
Contributor

subz3r0o0 commented Apr 2, 2024

great, thank you. is the issue mostly that the title is not aligned in the centre correctly across the job page

@Erioldoesdesign
Copy link
Member

great, thank you. is the issue mostly that the title is not aligned in the centre correctly across the job page

It is also that the navigation menu, if you look at the two screenshots is different, because the job's page has it's own index html in another repo on our account :)

@subz3r0o0
Copy link
Contributor

Hi there, I am currently working on this issue. I am slightly confused about how the subrepos link to the main repository. Thanks.

@Erioldoesdesign
Copy link
Member

Hi there, I am currently working on this issue. I am slightly confused about how the subrepos link to the main repository. Thanks.

I'm not sure I can give you much advice here other than you may need to 'pull' each repo separately and basically mimic/copy code across. I don't know if @AnXh3L0 or @SaptakS has better advice

@subz3r0o0
Copy link
Contributor

Should i message them? :)

@Erioldoesdesign
Copy link
Member

Should i message them? :)

Go for it :)

@subz3r0o0
Copy link
Contributor

Hi there @AnXh3L0 and @SaptakS, I am currently working on this issue. I am confused about how the subrepos link to the main repository. Thanks.

@Erioldoesdesign
Copy link
Member

Hi there @AnXh3L0 and @SaptakS, I am currently working on this issue. I am confused about how the subrepos link to the main repository. Thanks.

You might find they are quite busy but don't be afraid to ping them again in around 4-5 days they'll let you know if they are too busy to support :)

@subz3r0o0
Copy link
Contributor

Hi there @AnXh3L0 and @SaptakS, please let me know if you know if you see this message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error or something is not working correctly content Writing and/or design of content good first issue Small tasks with clear documentation about how and in which place you need to fix things in. Jobs An issue related to the Job board repo https://github.com/opensourcedesign/jobs
Development

No branches or pull requests

3 participants