Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of time cells is not consistent for different readers #137

Open
stof opened this issue Feb 13, 2023 · 3 comments
Open

Handling of time cells is not consistent for different readers #137

stof opened this issue Feb 13, 2023 · 3 comments

Comments

@stof
Copy link
Contributor

stof commented Feb 13, 2023

When reading a time cell in an ODS file, a DateIntervalCell is used. When reading a XLSX file, a DateTimeCell is used (and I don't know which date it has).
This makes it hard to write code that can support both XLSX and ODS as it forces to handle different cell types (both for reading and for writing). It would be great to have a common abstraction between those readers and writers to make the code common.

@stof
Copy link
Contributor Author

stof commented Aug 2, 2023

@Slamdunk is this something that is supposed to be abstracted properly ?

@Slamdunk
Copy link
Contributor

Slamdunk commented Aug 3, 2023

I haven't dug this, sorry.

If you are able to reasoning of the topic & code and propose a comprehensive solution in a PR, I'd be glad to review and merge it 💪

@stof
Copy link
Contributor Author

stof commented Aug 3, 2023

I don't have an idea right now but I'll try to think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants