Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow FileBasedStrategy on Windows #155

Closed
adawolfa opened this issue May 19, 2023 · 1 comment · Fixed by #156
Closed

Slow FileBasedStrategy on Windows #155

adawolfa opened this issue May 19, 2023 · 1 comment · Fixed by #156
Labels
bug Something isn't working

Comments

@adawolfa
Copy link
Contributor

This condition seems to be always passing on Windows, because $inMemoryTempFilePath is normalized using realpath() while the $tempFilePath is not.

variable value
$this->inMemoryTempFilePath C:\...\Temp\sharedstrings64676f752d764\sharedstrings0
$tempFilePath C:\...\Temp\sharedstrings64676f752d764/sharedstrings0

Notice the incorrect directory separator (a slash rather than a backslash) ahead of the base name part.

This causes the temporary file to be re-loaded on every single shared string access, making it very slow, especially on XLSX's with a lot of shared strings.
@Slamdunk
Copy link
Contributor

Thank you for noticing it: can you try the fix locally, and if works propose it in a Pull Request please?

@Slamdunk Slamdunk added the bug Something isn't working label May 22, 2023
@adawolfa adawolfa mentioned this issue May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

XLSX: Use platform appropriate directory separator for shared strings temp filename
2 participants
@Slamdunk @adawolfa