Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter and pagination for search #54

Closed
f-odhiambo opened this issue Mar 24, 2021 · 4 comments · Fixed by #106
Closed

Filter and pagination for search #54

f-odhiambo opened this issue Mar 24, 2021 · 4 comments · Fixed by #106
Assignees

Comments

@f-odhiambo
Copy link
Contributor

f-odhiambo commented Mar 24, 2021

This is a subtask of #50

@f-odhiambo f-odhiambo mentioned this issue Mar 24, 2021
16 tasks
@rkodev rkodev self-assigned this Apr 20, 2021
@rkodev
Copy link
Contributor

rkodev commented Apr 20, 2021

We can adapt the Jetpack paging library for this issue to create a continuous scrollable list that takes advantage of Room LiveData observables or use the old pagination technique of manually scrolling to the next page.

NB currently the SDC does not support directly observing Live Data on a Room database but it should be possible to implement this functionality using a custom data source

@vincent-karuri
Copy link
Contributor

@rkodev I don't know if the infinitely scrollable view is the most UX-friendly. The current mock-ups use the pagination style where we have a fixed number of patients per page.

I think a hybrid would be to support getting a specific number of entries per query to the DB and using the results to populate each page. Thoughts?

@rkodev
Copy link
Contributor

rkodev commented Apr 29, 2021

@vincent-karuri Yes, we have defaulted to adding the default patient pagination with a next and previous button at the bottom of the page

@f-odhiambo
Copy link
Contributor Author

There is an implementation of this on worth check-in out google/android-fhir#497 cc @vincent-karuri @rkodev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants