Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTC requirements for review #11

Closed
kroeckx opened this issue Mar 2, 2022 · 4 comments
Closed

OTC requirements for review #11

kroeckx opened this issue Mar 2, 2022 · 4 comments

Comments

@kroeckx
Copy link
Member

kroeckx commented Mar 2, 2022

Our policy currently says:

All submissions must be reviewed and approved by at least two committers, one of whom must also be an OTC member. Neither of the reviewers can be the author of the submission.

This means that if an OTC member is the author, we also need an OTC member to review it. I'm not sure if that was intentional or not.

@t-j-h
Copy link
Member

t-j-h commented Mar 2, 2022

It is intended. It is a simple approach and we will see how it works out in practice. We are not counting author as a meaningful reviewer in any context.

@levitte
Copy link
Member

levitte commented Nov 15, 2022

It is intended. It is a simple approach and we will see how it works out in practice. We are not counting author as a meaningful reviewer in any context.

Uhmmm, any context might be a bit broad, wouldn't you say? However, for the openssl/openssl repo, this is correct and what we have codified in our tools.

@levitte
Copy link
Member

levitte commented Nov 15, 2022

This can be closed, can it not?

@kroeckx
Copy link
Member Author

kroeckx commented Nov 15, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants