New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type_name member to provided methods and use it #14898
Conversation
240414f
to
7bf2369
Compare
7bf2369
to
0e347b1
Compare
Note that this will cause some failures, because the main naming standard we came up with for a number of ciphers differs from the "main name" we used in legacy. The new "main names" have a more consistent pattern, so I would suggest that the tests should be adapted accordingly rather then flipping back the algorithm naming scheme. This is an exercise for another PR, I'd say. |
0e347b1
to
014ad24
Compare
Ping for review(s)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might I suggest this addition?
diff --git a/doc/man7/openssl-core.h.pod b/doc/man7/openssl-core.h.pod
index 8158e3f421..866abd581d 100644
--- a/doc/man7/openssl-core.h.pod
+++ b/doc/man7/openssl-core.h.pod
@@ -60,6 +60,9 @@ identity zero and function pointer NULL.
The algorithm names and property definitions are defined by the
providers.
+The OpenSSL libraries use the first of the algorithm names as the main
+or canonical name, on a per algorithm implementation basis.
+
=item B<OSSL_PARAM>
This type is a structure that allows passing arbitrary object data
Other than that addition, this looks fine |
Fixup adding the suggested paragraph pushed. @levitte PTAL |
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
One of the CI jobs had failed to even start, so I decided to re-run them all. Looks much better now. |
Merged to master. Thank you for the review. |
Fixes #14701
Checklist