3.0.3 Compilation problems

[WyzHyl]

crypto/bn/bn_dh.c:34:5: error: initializer element is not constant
crypto/bn/bn_dh.c:34:5: error: (near initialization for 'modp_1536_p[0]')

Error when compiling 3.0.3, 1.X version does not have this problem，The compiler used is the ARM cross compiler

[paulidale]

ca2bf55 is the culprit commit.

[t8m]

Except this is a clear bug of the compiler - the initializer is a constant expression.

[paulidale]

I've seen a few (ancient) compilers didn't like constant expressions.

The C89 standard says it is allowed in 6.5.7 but doesn't admit it in foot note 54 in 6.4 which defines constant expressions. It doesn't appear to mandate that constant expressions are evaluated at compiler time (they can be).

C99 mandates that they are evaluated at compile time.

[paulidale]

I think the answer to the original question is your compiler is at fault.

[WyzHyl]

I think the reason is that the compiler I'm using doesn't recognize this form of initialization
static const BN_ULONG modp_1536_p[] = {
BN_DEF(0xFFFFFFFF, 0xFFFFFFFF), BN_DEF(0xCA237327, 0xF1746C08),

[t8m]

Yes, and that's a serious deficiency of the compiler as it is just a preprocessor macro expanding to a simple constant expression (BN_ULONG)0xF1746C08 << 32 | 0xCA237327