Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined behaviour in ssl_session_calculate_timeout() in 3.1/3.0 #24046

Open
mattcaswell opened this issue Apr 5, 2024 · 1 comment
Open

Undefined behaviour in ssl_session_calculate_timeout() in 3.1/3.0 #24046

mattcaswell opened this issue Apr 5, 2024 · 1 comment
Labels
branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 triaged: bug The issue/pr is/fixes a bug

Comments

@mattcaswell
Copy link
Member

The function ssl_session_calculate_timeout adds a time to a timeout value but does not check for possible overflow in 3.1/3.0. Therefore setting a very large timeout value using SSL_SESSION_set_timeout can cause undefined behaviour.

This is not the case in 3.2/3.3/master where we do the addition safely.
@mattcaswell mattcaswell added triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Apr 5, 2024
@mattcaswell mattcaswell mentioned this issue Apr 5, 2024
Closed
@nhorman
Copy link
Contributor

nhorman commented Jun 5, 2024

Given that openssl 3.1 and 3.0 will be supported until sometime in 2026, we should consider fixing this, but its perhaps not a high priority unless someone is encountering this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhorman @mattcaswell