Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QLOG logging infrastructure - impl - framework #210

Closed
Tracked by #53
hlandau opened this issue Sep 7, 2023 · 7 comments
Closed
Tracked by #53

QLOG logging infrastructure - impl - framework #210

hlandau opened this issue Sep 7, 2023 · 7 comments
Assignees
Labels
Milestone

Comments

@hlandau
Copy link
Member

hlandau commented Sep 7, 2023

No description provided.

@hlandau
Copy link
Member Author

hlandau commented Nov 28, 2023

Blocked on #279

@arapov
Copy link
Member

arapov commented Nov 29, 2023

@hlandau I believe the block can be removed. We must have this feature in master, although with a proper disclaimer. IIRC, we discussed this only at the WG call; it is important to communicate this to @openssl/otc and see if there are no objections.

@hlandau
Copy link
Member Author

hlandau commented Nov 29, 2023

@hlandau I believe the block can be removed. We must have this feature in master, although with a proper disclaimer. IIRC, we discussed this only at the WG call; it is important to communicate this to @openssl/otc and see if there are no objections.

My preferred route to do this is via openssl/general-policies#59, and feedback there is still desired.

If we do not have the ability to make that happen, or make it happen rapidly enough, it's certainly true we can make this happen. Experimental features would be my preferred route. But there are some other options to manage the risk/instability.

@t-j-h
Copy link
Member

t-j-h commented Nov 29, 2023

This is not an experimental feature - it is a core feature that we need to have in the release and need to have it available.
That the format might change isn't an issue in reality that would mean we have to put this in a special category and not have it available by default. It just needs to be made clear if the QLOG spec updates we will follow it.
Sharing stuff in QLOG format is a core QUIC stack feature in my view.

@hlandau
Copy link
Member Author

hlandau commented Dec 18, 2023

If the format is changing then in my view it's the very definition of an experimental feature. "Not having it available by default" is the entire point of this.

"If the QLOG spec updates we will follow it" — this doesn't even implement the current draft version of the QLOG spec. It deliberately implements the prior draft version of the QLOG spec because that's the version currently supported by QVIS. In other words I chose to implement the version QVIS supports rather than the current state of the I-D.

It is correct that it is a question of how feature stability is communicated. That is the entire reason for the proposed policy.

@t8m t8m linked a pull request Jan 11, 2024 that will close this issue
@t8m
Copy link
Member

t8m commented Jan 11, 2024

PR openssl/openssl#22037 is ready for review. Marking this as done.

@arapov arapov added this to the OpenSSL 3.3 milestone Jan 22, 2024
@hlandau
Copy link
Member Author

hlandau commented Feb 1, 2024

openssl/openssl#22037 has merged.

@hlandau hlandau closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants