Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Replace usage of netloc filters to urlsplit
Browse files Browse the repository at this point in the history
Remove the references to netorigin and netloc_no_port as they will
be taken out from openstack-ansible-plugins

Now using ansible 2.4's urlsplit filter as a replacement.

Change-Id: I94302ced3e5d6faa4d8748590f323e89d9b7280c
Related-Bug: #1820830
  • Loading branch information
GeorginaShippey committed Mar 21, 2019
1 parent 6638604 commit dcd9469
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions tasks/repo_build_prepare.yml
Expand Up @@ -129,7 +129,7 @@
virtualenv_site_packages: "no"
extra_args: >-
--index-url {{ repo_build_pip_default_index }}
--trusted-host {{ repo_build_pip_default_index | netloc_no_port }}
--trusted-host {{ repo_build_pip_default_index | urlsplit('hostname') }}
--constraint {{ repo_build_release_path }}/requirements_constraints.txt
{{ pip_install_options | default('') }}
register: install_packages
Expand All @@ -145,7 +145,7 @@
virtualenv_site_packages: "no"
extra_args: >-
--index-url {{ repo_build_pip_default_index }}
--trusted-host {{ repo_build_pip_default_index | netloc_no_port }}
--trusted-host {{ repo_build_pip_default_index | urlsplit('hostname') }}
--constraint {{ repo_build_release_path }}/requirements_constraints.txt
{{ pip_install_options | default('') }}
register: install_packages
Expand Down
8 changes: 4 additions & 4 deletions tasks/repo_build_wheels.yml
Expand Up @@ -47,10 +47,10 @@
--no-binary :all:
--constraint {{ repo_build_release_path }}/requirements_constraints.txt
--index-url {{ repo_build_pip_default_index }}
--trusted-host {{ repo_build_pip_default_index | netloc_no_port }}
--trusted-host {{ repo_build_pip_default_index | urlsplit('hostname') }}
{% if repo_build_pip_extra_indexes is defined %}
--extra-index-url {{ repo_build_pip_extra_indexes | join(' --extra-index-url ') }}
--trusted-host {{ repo_build_pip_extra_indexes | map('netloc_no_port') | join(' --trusted-host ') }}
--trusted-host {{ repo_build_pip_extra_indexes | map(urlsplit('hostname')) | join(' --trusted-host ') }}
{% endif %}
--requirement {{ repo_build_release_path }}/requirements.txt
{{ pip_install_options }}
Expand All @@ -72,10 +72,10 @@
--no-binary {{ repo_build_pip_no_binary | join(' --no-binary ') }}
{% endif %}
--index-url {{ repo_build_pip_default_index }}
--trusted-host {{ repo_build_pip_default_index | netloc_no_port }}
--trusted-host {{ repo_build_pip_default_index | urlsplit('hostname') }}
{% if repo_build_pip_extra_indexes is defined %}
--extra-index-url {{ repo_build_pip_extra_indexes | join(' --extra-index-url ') }}
--trusted-host {{ repo_build_pip_extra_indexes | map('netloc_no_port') | join(' --trusted-host ') }}
--trusted-host {{ repo_build_pip_extra_indexes | map(urlsplit('hostname')) | join(' --trusted-host ') }}
{% endif %}
--build {{ repo_build_dir }}
--requirement {{ repo_build_release_path }}/requirements.txt
Expand Down
2 changes: 1 addition & 1 deletion tests/test-repo-build.yml
Expand Up @@ -52,7 +52,7 @@

- name: Set Ubuntu Cloud Archive repo URL based on discovered information
set_fact:
uca_apt_repo_url: "{{ ubuntu_repo_url.stdout | netorigin }}/ubuntu-cloud-archive"
uca_apt_repo_url: "{{ ubuntu_repo_url.stdout | urlsplit('scheme') ~ '://' ~ urlsplit('netloc') }}/ubuntu-cloud-archive"
when:
- ansible_pkg_mgr == 'apt'
- nodepool.stat.exists | bool
Expand Down

0 comments on commit dcd9469

Please sign in to comment.