Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Commit

Permalink
Adds new "--no-inflight-validations" option to deploy CLI
Browse files Browse the repository at this point in the history
This provides an independant way to activate or not the in-flight
validations within a deploy.
The default is to have them running, and this option allows to
deactivate the in-flight ones.

Change-Id: I81e934e2978cad4e2713d54e19a57c84a6ac0b52
  • Loading branch information
cjeanner committed Aug 15, 2019
1 parent 055443d commit bf48dbc
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 4 deletions.
@@ -0,0 +1,5 @@
---
features:
- |
Introduce new "--no-inflight-validations" option in order to deactivate
those validations. It defaults to "False", since we want them by default.
15 changes: 11 additions & 4 deletions tripleoclient/v1/overcloud_deploy.py
Expand Up @@ -722,6 +722,16 @@ def get_parser(self, prog_name):
'use the --run-validations flag. These validations are '
'now run via the external validations in '
'tripleo-validations.'))
parser.add_argument(
'--no-inflight-validations',
action='store_true',
default=False,
dest='no_inflight',
help=_('Deactivate in-flight validations during the deploy. '
'In-flight validations provide a robust way to ensure '
'deployed services are running right after their '
'activation. Defaults to False.')
)
parser.add_argument(
'--dry-run',
action='store_true',
Expand Down Expand Up @@ -915,9 +925,6 @@ def take_action(self, parsed_args):
deployment_options['ansible_python_interpreter'] = \
parsed_args.deployment_python_interpreter

disabled_val = parsed_args.disable_validations
enable_val = parsed_args.run_validations

deployment.config_download(
self.log, self.clients, stack,
parsed_args.templates, parsed_args.overcloud_ssh_user,
Expand All @@ -928,7 +935,7 @@ def take_action(self, parsed_args):
timeout,
verbosity=self.app_args.verbose_level,
deployment_options=deployment_options,
in_flight_validations=(enable_val or not disabled_val))
in_flight_validations=(not parsed_args.no_inflight))
except Exception:
deployment.set_deployment_status(
self.clients, 'failed',
Expand Down

0 comments on commit bf48dbc

Please sign in to comment.