Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Commit

Permalink
Explicitely pass RSYNC_PASSWORD when uploading logs to ci.c.o artifacts
Browse files Browse the repository at this point in the history
The rdo-jenkins.ci.centos.org jenkins slave has an implicit export
of RSYNC_PASSWORD located in .bash_profile which is sourced when
spawning a new shell.
However, this variable is already available and configured on the
jenkins slave (in the ci.c.o web interface).

When setting up and testing new slaves without that .bash_profile
export, the RSYNC_PASSWORD variable was not available in that context.
The RSYNC_PASSWORD variable is available on the machine running Ansible,
the jenkins slave, but not the duffy node.

We noticed the issue when weirdo jobs would be able to upload
artifacts while the quickstart jobs failed.

Change-Id: I6aababdf48fe8a5b19acaecb1b8427a68591973f
  • Loading branch information
David Moreau-Simard committed Jul 29, 2016
1 parent c0708ce commit 1b2b0b8
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tasks/main.yml
Expand Up @@ -186,7 +186,9 @@
when: artcl_rsync_logs|bool and artcl_rsync_use_daemon == false

#centos-ci
- name: upload to the artifact server using pubkey auth
- name: upload to the artifact server using password auth
environment:
RSYNC_PASSWORD: "{{ lookup('env', 'RSYNC_PASSWORD') }}"
shell: >
rsync -av {{ artcl_collect_dir }}/ {{ artcl_rsync_path }}/$BUILD_TAG
retries: 5
Expand Down

0 comments on commit 1b2b0b8

Please sign in to comment.