Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateFormPostUri can cause subtle bugs #604

Open
carolynvs opened this issue Feb 17, 2016 · 0 comments
Open

CreateFormPostUri can cause subtle bugs #604

carolynvs opened this issue Feb 17, 2016 · 0 comments

Comments

@carolynvs
Copy link
Member

CreateFormPostUri takes a Uri for the redirect value and if the value supplied does not have a file extension, e.g. http://example.com, Uri will quietly change it to http://example.com/. This easily leads to invalid signature exceptions because the redirect value in the form and hash are different.

Since nothing is gained by using a Uri as a parameter, I suggest switching to string when we revisit Object Storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant