Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing comma in search_fields breaks /admin search #1238

Closed
code-review-doctor opened this issue Jan 4, 2022 · 0 comments
Closed

Missing comma in search_fields breaks /admin search #1238

code-review-doctor opened this issue Jan 4, 2022 · 0 comments

Comments

@code-review-doctor
Copy link

search_fields should be a list or tuple according to django docs but it's a str:

openstax-cms/webinars/wagtail_hooks.py

Line 10 in ad9cd28

search_fields = ('title')

Notice the lack of a comma, so this gets evaluated to a str. A one item tuple must end in a comma so Python knows it's a tuple.

I can make a PR to fix this for you?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwvolo @code-review-doctor