Rounding not correct

[elrafman]

Hi
when sending the order amount to the saferpay the amount is sometimes not rounded correctly

the calculation
intval(Mage::helper('saferpay_be')->round($amount, 2) * 100)
should be replaced by
intval(round(Mage::helper('saferpay_be')->round($amount, 2) * 100))
as you may have problems using intval with floating point numbers.

Cheers

Rafael

[tim-bezhashvyly]

Hi Rafael.

Can you please tell under which conditions you got wrong rounding so I can check it?

Thanks,
Tim.

[danielgratzl]

It's line 285 in app/code/community/Saferpay/Ecommerce/Model/Abstract.php of your current implementation

 'AMOUNT'                => intval($helper->round($this->getOrder()->getGrandTotal(), 2) * 100)

as elrafman suggests you should change this to

 'AMOUNT'                => intval(round($helper->round($this->getOrder()->getGrandTotal(), 2) * 100))

All this hassle is caused by this http://en.wikipedia.org/wiki/Floating_point#Accuracy_problems

Use 23.80 as a testcase.. With your current version it calculates to 2379 which is obviously incorrect