Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use openstreetmap.style config file for tileservers #64

Closed
gravitystorm opened this issue May 16, 2016 · 4 comments
Closed

Use openstreetmap.style config file for tileservers #64

gravitystorm opened this issue May 16, 2016 · 4 comments

Comments

@gravitystorm
Copy link
Contributor

We've noticed that the tileservers use the default .style file from osm2pgsql when processing updates (by not specifying one, it defaults to the default.style)

https://github.com/openstreetmap/chef/blob/master/cookbooks/tile/templates/default/replicate.erb#L69-L74

The openstreetmap-carto project includes a style file for use with osm2pgsql. This ensures that the database layout matches what the stylesheets expect, as well as allowing use of arbitrary osm2pgsql versions instead of forcing people to upgrade to the latest if columns get changed.

I believe there's no substantial differences between the master version in osm2pgsql and that in the latest openstreetmap-carto release, so this is not currently a major issue. But it might be worth changing the update script (and the import script, if there is one).

@tomhughes
Copy link
Member

So you're right that there are no differences, or rather all the differences are in comment lines.

The problem we have is that although we only have one layer at the moment the cookbook is designed to support have multiple layers with different styles, but only one database to support them, which means there is no obvious way to decide which style's style file to use.

@pnorman
Copy link
Collaborator

pnorman commented Aug 12, 2016

cookbook is designed to support have multiple layers with different styles, but only one database to support them

This will break with 3.0 of OpenStreetMap Carto. Well, it would if not for the fact that we're not using the functionality.

@kocio-pl
Copy link

Isn't this issue resolved, now that we have osm-carto v4.0.0 deployed already?

@pnorman
Copy link
Collaborator

pnorman commented Jul 10, 2017

Resolved with 02f9c7c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants