Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset for landuse=salt_pond #258

Closed
Mahabarata opened this issue Oct 27, 2021 · 4 comments
Closed

Add preset for landuse=salt_pond #258

Mahabarata opened this issue Oct 27, 2021 · 4 comments

Comments

@Mahabarata
Copy link

Mahabarata commented Oct 27, 2021

Description

Hi,

on ID, when we choose landuse:salt_pond, there is no translation in french.
Probably because when I go to transifex, salt_pond is missing
Could you add it ?

Best regards

edit on 21 Dec 2021 =
because this issue is still open and I found another 'landuse' missing, I add this request.
We don't have either in transifex "landuse=depot" so no translation in ID.
Could you add it too ?
Thanks.

@1ec5
Copy link
Contributor

1ec5 commented Oct 28, 2021

Hi, iD’s presets are maintained in the id-tagging-schema repository. There isn’t a preset for landuse=salt_pond in there yet, but it would be a reasonable feature request in that repository.

@mbrzakovic mbrzakovic transferred this issue from openstreetmap/iD Oct 28, 2021
@Mahabarata Mahabarata changed the title Add preset for landuse=salt_pond Add preset for landuse=salt_pond and landuse=depot Dec 21, 2021
@matkoniecz
Copy link
Contributor

matkoniecz commented Jan 10, 2022

I would be strongly against landuse-depot

This tag is frequently used to everything that can be called depot including tram depots, warehouses, container depots, bus depots, aircraft boneyards, areas for storage of produced vehicles, railway yards and more. Such mix of features in one tag is not really useful, and most of them are well covered by existing tags.

See also gravitystorm/openstreetmap-carto#3480 gravitystorm/openstreetmap-carto#2989 gravitystorm/openstreetmap-carto#1716 (all are "Add rendering for landuse=depot")

Disclaimer: I am primary author of https://wiki.openstreetmap.org/wiki/Tag:landuse%3Ddepot page - this should not be really taken as independent confirmation of the comment above.


EDIT: addressing comment below:

We use water= or wetland= to be more specific. So why not for landuse=depot ?

natural=wetland wetland=* is used for things that are in one sane group

landuse=depot grups bus depots and aircarft boneyards and container warehouses and road salt storage.

So if we want to talk about depot, we should look at depot=bus.

When the biggest problem is putting multiple distinct things together then ignoring it is not a good way to address the complaint.

@tyrasd tyrasd changed the title Add preset for landuse=salt_pond and landuse=depot Add preset for landuse=salt_pond Jan 10, 2022
@Mahabarata
Copy link
Author

According to taginfo, the key "depot" is used with the value "bus" 819 times. Next value is "container", only 158 times and the next one (tram) only 74 times.

So if we want to talk about depot, we should look at depot=bus.

Bus are big, buildings cost money, so a lot of areas for bus are open spaces.

There are 2 possibilities for areas with buses :

  • it is a place for companies that build buses. They store their buses before to sell them : this area clearly is an industrial area
  • it is a place for companies using buses as a service, they store their buses at night because not using them : a service company should use the key "commercial", this area is clearly a commercial area.

The areas of the first kind are very few in the world : there are few companies that build buses and each company has very few places where they build and store their buses.
But the second kind is huge : almost all medium and big cities have a transportation company and all have to put their buses somewhere at night.

It means that (if I use alternative tags) industrial=depot should be a very small number and commercial=depot should be a big one in osm.

In taginfo, it is the exact opposite (more than 3,000 for industrial, less than 50 for commercial) !

I see several reasons for that :

  • because of the wiki page for industrial=depot : it is clearly a bad definition, the page talks about commercial=depot and not about industrial=depot
  • because of the wiki page for commercial=depot : there is no page.
  • when I use "landuse=commercial+commercial=depot" I have in ID "commercial area" = when I see that, I try to find something else for my depot of buses
  • when I use "landuse=industrial+industrial=depot" I have in ID "industrial area" = when I see that, I try to find something else for my depot of buses
  • if I search "depot" in ID or another word like storage, store, warehouse... I never find something which fit with a depot for buses (but sometimes I find very strange tags. Maybe the funniest = with "depot" we find "psychotherapist" ?!)

Some other informations. When I look for "depot=bus" (819 items with these tags according to taginfo) with overpass, I find today :

  • 481 landuse=depot
  • 238 industrial=depot (or bus_depot)
  • 43 building=yes, depot, garage, commercial or industrial
  • 25 commercial=depot or similar
  • 18 amenity=parking
  • 15 landuse=garages
  • 15 amenity=bus_depot, bus garages, bus station, depot

According of what I read in the links you put, the winner should be commercial=depot but it is not what we find in osm.

Somewhere I read that osm was what contributors put in it.
Some use industrial=depot because of the bad wiki page. Without these bad informations, probably everybody will use landuse=depot.

Conclusion :

  • osm is what contributors put in it
  • contributors, when using "depot", it is for a bus depot
  • contributors, when using depot=bus, use first landuse=depot, sometimes landuse=industrial but it is probably an error because of the wiki page

You are right when you say that landuse=depot could be used with a lot of different kinds of depot. Is it really a problem ? There are many different things for natural=water, for natural=wetland. We use water= or wetland= to be more specific. So why not for landuse=depot ?

A preset for landuse=depot seems to me the best choice.

Best regards

@tyrasd
Copy link
Member

tyrasd commented Jan 17, 2022

Hey @Mahabarata! I appreciate your effort to explain your reasoning of proposing landuse=depot as a new preset. But I do also see that the tag is also clearly not unproblematic, as outlined by @matkoniecz above. I think this issue tracker is really not a good place to discuss these tagging questions, however. Could you please try to find a better forum to clarify the tagging of various kinds of depots, for example the tagging mailing list would be a better option in my opinion?

PS:

if I search "depot" in ID or another word like storage, store, warehouse... I never find something which fit with a depot for buses (but sometimes I find very strange tags. Maybe the funniest = with "depot" we find "psychotherapist" ?!)

This one was easy to fix by adding search term to the respective alternative presets: b213170.


For now, I would like to limit this ticket to the addition of the originally proposed landuse=salt_pond tag.

@tyrasd tyrasd closed this as completed in ac8b282 Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants