Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Services field for bicycle on shops #464

Closed
brierjon opened this issue May 20, 2022 · 1 comment
Closed

Addition of Services field for bicycle on shops #464

brierjon opened this issue May 20, 2022 · 1 comment

Comments

@brierjon
Copy link

Mostly applicable to shop=bicycle, shop=outdoor, shop=sports the bicycle services keys should be displayed for these shop types. https://wiki.openstreetmap.org/wiki/Key:service:bicycle and could replace #43, but is different in that adding services would not change the primary label for the store type. Changing on tag combination if desired could be separate logic than needed to add a field to answer yes/no for each of these tags.

Example for inclusion of outdoor shops as REI has bike shops offering bicycle repair services.

Example for inclusion of sports shops as Dicks Sporting Goods has bike repair as a service.

Having the ID UI expose these tags in a structured field either starting with "unknown" and accommodating yes/no/only/separate depending on the tag's scope.

Currently these only display in the tags field, but are useful metadata to have about bicycle services.
image

@1ec5
Copy link
Contributor

1ec5 commented May 20, 2022

The existing Services field for service:bicycle:* would be added to the Sports Store and Outdoors Store presets, which are what stores like Dick’s and REI are using:

"key": "service:bicycle:",
"fields": [
"name",
"operator",
"sport",
"{shop}"
],
"fields": [
"{shop}",
"clothes"
],

To avoid confusion, the field should probably be renamed to Bicycle Services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants