Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xmas:feature preset #721

Open
miche101 opened this issue Dec 28, 2022 · 6 comments
Open

Add xmas:feature preset #721

miche101 opened this issue Dec 28, 2022 · 6 comments

Comments

@miche101
Copy link

OSM Tag(s)

xmas:feature=*

How would you like this tag to see supported?

As a Preset

Label

Christmas Tree, Market....

Aliases

Xmas, Santa, Christmas

Terms

Xmas, Santa, Christmas

Link to OSM Wiki page

https://wiki.openstreetmap.org/wiki/Key:xmas:feature

Status of the Tag

In Use

Usage of the tag

2503

Replaces other Tag?

no

Regional Tag?

in some parts of the world

Further Information

Merry Christmas :),

I would like to request the inclusion of xmas:feature in iD's presets.

taginfo
https://taginfo.openstreetmap.org/keys/xmas:feature

JOSM-Preset
https://josm.openstreetmap.de/wiki/Presets/Xmas

best regards
Miche101

@miche101 miche101 added the enhancement New feature or request label Dec 28, 2022
@Elefant-aus-Wuppertal
Copy link
Contributor

Elefant-aus-Wuppertal commented Jan 6, 2023

What I would find super interesting in this context is to unify how to tag visit dates / dates of when the existence was checked last time (check_date) of the xmas features uniformly.

Although, @miche101, I think you're working on it right now, right?

Back then, my suggestion to expand the use of check_date in iD was rejected: openstreetmap/iD#7414
(that was not related to the xmas:features though).

@miche101
Copy link
Author

miche101 commented Jan 7, 2023

hi,

xmas:day_date and xmas:opening_hours better united in one value? Yes, that would be better, but wouldn't be easy for the mappers. You would then have something like this:

opening_hours="2019 Jul 23 05:00-24:00; 2019 Jul 24-2019 Jul 26 00:00-24:00; 2019 Jul 27 00:00-18:00"

Oh my god! ... There is also no tool that does that for the user.

Yes, I'm working on cleaning up a lot of things. The German wiki in particular differs from the English wiki in a few things. Many things were still invented in the German Wiki.

But I have to be careful because OSMand already has support for 4 XMas-feature (tree, market, shop, pyramid) not to break it.

OSMand understands: xmas:name, xmas:day_date, xmas:location, xmas:opening_hours (partial support only), xmas:url, xmas:note... from what I know.

check_date helps when you say you have a lot of dates and are looking for dates that are probably out of date. For example, you want all OSM objects that have not been processed for 15 years. You check everything, what do you do with those where there is nothing to change or add. You can add Check_date or move the object by one meter, I find adding Check_date= better. But if adding is too complicated, many will simply move.

A button to set the current one would be enough..

best regards
Miche101

@Elefant-aus-Wuppertal
Copy link
Contributor

I see. Thanks for your quick answer.

xmas:day_date and xmas:opening_hours better united in one value?

Maybe you don't have to go that far. I rather meant maybe not using xmas:lastcheck anymore and then check_date (or better probably xmas:check_date) instead

xmas:day_date can remain in my view.

The German wiki in particular differs from the English wiki in a few things. Many things were still invented in the German Wiki.

True.

For example, I noticed that in the German Wiki for xmas:feature=market all additional tags with namespace, for example xmas:opening_hours, are suggested,
for other features like xmas:feature=shop + xmas:feature:shop=christmas_tree the "normal" opening_hours key can be used according to the wiki.

Whether one could achieve uniformity in this regard, especially as far as the preset is concerned?

The advantage of namespace "xmas:..." is of course that the opening hours of a xmas:feature=market can be clearly assigned with xmas:opening_hours if the Christmas market takes place at an amenity=marketplace, for example, which has its own opening_hours.

If so, I would definitely be in favor of implementing all additional tags in the preset with the xmas namespace.

@miche101
Copy link
Author

miche101 commented Jan 7, 2023

xmas:lastcheck and check_date. Until 2016, the German wiki also had check_date

Anything with xmas: is not a good idea. You have to look closely. A Christmas tree that is a natural tree would you have to have double keys for everything? A store that sells Chist trees would have to do all the keys twice

I'm definitely not in favor of it, because then I might as well close the issues. Because the namespace is more of a reason to refuse the recording..

@tyrasd tyrasd added new-preset and removed enhancement New feature or request labels Jan 10, 2023
@miche101
Copy link
Author

miche101 commented Jan 24, 2023

I tried a preset to write, I don't know if it works..
data.zip

What's the best way to do that? ( National Christmas Tree ) a add to preset tree.json ... natural and matchScore?

To market and event i add seasonal=christmas because you can enter everything without XMAS: , works with my site https://greymiche.lima-city.de/xmas/

@miche101
Copy link
Author

miche101 commented Jan 24, 2023

or more fields for the most used xmas:* Keys xmas:name, xmas:day_date, xmas:location, xmas:opening_hours, xmas:url ..

Because what to do with things like this:
Weihnachtskerze, Weihnachtshaus Neuwied and Blauer Lichterglanz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants