Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate old passwords #1006

Open
tomhughes opened this issue Nov 30, 2023 · 2 comments
Open

Invalidate old passwords #1006

tomhughes opened this issue Nov 30, 2023 · 2 comments
Labels

Comments

@tomhughes
Copy link
Member

tomhughes commented Nov 30, 2023

We are planning to invalidate old passwords on the main site which have not been used for a long time and are not hashed to modern standards. The current count of affected users is:

  • 7001 users with unsalted MD5 hashes (have not changed password since 2007, or logged in since 2013)
  • 1473214 users with salted MD5 hashes (have not logged in since 2013)
  • 958 users without valid passwords

The plan is to clear all these password and to change the web site code to offer to do an email password reset if a user with a blank password tries to login.

@grischard
Copy link
Collaborator

grischard commented Dec 1, 2023

Out of these 958 without valid passwords (null passwords?), there could be accounts created yesterday, correct?

Is there any overlap between the 958 and the others? I'm thinking we could show a different message for all cohorts, depending on whether the account has an oauth provider linked or not; something like:

if ${oauth_account_provider):

"Your account, linked through ${oauth_account_provider), does not have a password. We require you to set one as part of our enhanced security measures. This is a proactive step, and does not indicate any security breach. Check your email for a password reset link."

else:

"Welcome back! Since you last logged in, we've upgraded our security systems to better protect your data. This upgrade requires a new password for accounts with older encryption formats, ensuring your account meets our current security standards. This is a proactive step, and does not indicate any security breach. Check your email for a password reset link."

@tomhughes
Copy link
Member Author

There is such a thing as overengineering you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants