Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it OK to use /api/0.6/notes/search with large limits? #189

Closed
matkoniecz opened this issue Jan 3, 2018 · 5 comments
Closed

Is it OK to use /api/0.6/notes/search with large limits? #189

matkoniecz opened this issue Jan 3, 2018 · 5 comments
Labels
service:api issues related to the API

Comments

@matkoniecz
Copy link

I am not sure whatever in ENT8R/NotesReview#1 I worry without a good reason or is it a good idea to reduce default limit to avoid overloading API.

I am also not certain is it the best place to ask, but I was unaware about a better one.

@zerebubuth
Copy link
Collaborator

10,000 does seem like a lot! But that's the limit set in the source code, and I've no reason to expect it wouldn't be OK.

Perhaps give it at a go against the development / testing server and see if it has acceptable performance there? If we see that there are problems, we might need to reduce it at a later date.

@matkoniecz
Copy link
Author

Perhaps give it at a go against the development / testing server and see if it has acceptable performance there?

Is my interpretation "development / testing server has lower performance and potential problems will be easier to notice, queries with decent performance on dev server are likely to not use too many resources" correct?

@zerebubuth
Copy link
Collaborator

Is my interpretation "development / testing server has lower performance and potential problems will be easier to notice, queries with decent performance on dev server are likely to not use too many resources" correct?

It's certainly the case that if the performance is terrible then we'll notice it on the dev server, and might be able to fix it before hurting the main production site.

But it's not always the case that things which run well on the dev server will run well on the production site, as the dev server has a tiny fraction of the data that the production site has, and runs on completely different hardware. But the good news is that we can try and fake it by adding a whole bunch of notes on the dev server to test how it scales.

Another possibility is that we could add a better interface for dealing with note data in bulk. Would a "note changes stream" similar to the minutely diffs be useful?

@pnorman
Copy link
Collaborator

pnorman commented Jan 5, 2018

Another possibility is that we could add a better interface for dealing with note data in bulk. Would a "note changes stream" similar to the minutely diffs be useful?

Yes. People currently fake this by fetching note n+1 and pausing when it fails, but this is hackish, fails when the serial goes up by more than one, and isn't a great design.

I don't know if a notes stream helps this particular use-case, but there are others it would.

@pnorman pnorman added the service:api issues related to the API label Feb 27, 2019
@pnorman
Copy link
Collaborator

pnorman commented May 26, 2022

Question was answered, and although a new notes change stream would be nice, this issue isn't the right place for that to develop.

@pnorman pnorman closed this as completed May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service:api issues related to the API
Projects
None yet
Development

No branches or pull requests

3 participants