WIP: Experimental middle implementations #1384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joto
force-pushed
the
wip-middle-experiments
branch
3 times, most recently
from
8252c36
to
7ef0214
Compare
joto
force-pushed
the
wip-middle-experiments
branch
from
7ef0214
to
9c1cb3c
Compare
joto
force-pushed
the
wip-middle-experiments
branch
from
9c1cb3c
to
4500721
Compare
joto
force-pushed
the
wip-middle-experiments
branch
3 times, most recently
from
b4b22b7
to
48551fa
Compare
joto
force-pushed
the
wip-middle-experiments
branch
from
48551fa
to
4017a74
Compare
|
New version of this PR. The 'mem' middle has been removed, because it has been merged into master. |
joto
force-pushed
the
wip-middle-experiments
branch
from
4017a74
to
b3936d9
Compare
joto
force-pushed
the
wip-middle-experiments
branch
from
b3936d9
to
d810b92
Compare
joto
force-pushed
the
wip-middle-experiments
branch
from
d810b92
to
bd7faf5
Compare
This commits adds a new middle implementations 'db' which is similar to 'pgsql'. All data is stored in the database. A new table structure with JSONB for tags and relation members is used. This is EXPERIMENTAL! Not well tested, not complete and performance might be horrible. It is intended to start a discussion about what we need and how to best implement it. To enable these, set the environment variable OSM2PGSQL_MIDDLE to either 'db' or 'new'. If set to 'db' use of the new middle is forced, independent of the '--slim' setting! Or you can set it to 'new' in which case the 'db' middle will be used instead of the 'pgsql' middle if and when that would have been used. This way of setting the middle is temporary and gives us flexibility while experimenting, it will not be available in this form in the final implementation. The new middle has various options that can be set with the OSM2PGSQL_MIDDLE_OPTS environment variable. Use a comma separated list of options, a leading '-' disables the option. Options: * drop_tables * forward_dependencies * has_bucket_index * tags * attributes * untagged_nodes * locations * way_nodes * relation_members
joto
force-pushed
the
wip-middle-experiments
branch
from
bd7faf5
to
c0185e3
Compare
|
osm2pgsql has changed quite a lot since this PR was made and it isn't really useful any more. Closing here. We are still planning to reintroduce something like this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new middle implementations:
dbis similar topgsql. All data is stored in the database. A new table structure with JSONB for tags and relation membersis used.
memis similar toram. It only stores node locations and way node lists in RAM. Used for import-only workflows that donot need the flex-output two-stage processing.
These are EXPERIMENTAL! They are not well tested, not complete and performance might be horrible. They are intended to start a discussion about what we need and how to best implement it. This PR will evolve over time.
To enable these, set the environment variable
OSM2PGSQL_MIDDLEto eitherdbormem. This setting is independent of the--slimsetting! This way of setting the middle is temporary and gives us flexibility while experimenting, it will not be available in this form in the final implementation.More about this on in my blog.