Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DI test utils into @opensumi/di #130

Closed
erha19 opened this issue Dec 15, 2021 · 2 comments
Closed

Move DI test utils into @opensumi/di #130

erha19 opened this issue Dec 15, 2021 · 2 comments
Labels
⚙️ refactor Refactor code

Comments

@erha19
Copy link
Member

erha19 commented Dec 15, 2021

现状

当前测试中有许多 Mock 方法依赖 tools/dev-tool 目录内的工具方法,这部分方法应当整合到 @opensumi/di

期望

DI 提供测试相关的工具函数

@erha19 erha19 self-assigned this Dec 15, 2021
@erha19 erha19 changed the title move injector helper and mock utils into @opensumi/di Move DI test utils into @opensumi/di Dec 15, 2021
@erha19 erha19 removed their assignment Dec 17, 2021
@erha19
Copy link
Member Author

erha19 commented Dec 17, 2021

@suyu34 这里

@bytemain
Copy link
Member

看了看,dev-tools/inject-helper mock-injector 其实还是有一些业务逻辑的,比如 mock 中还是带了一些 MockCommand 之类的,其实不好都迁移到 di 中。

我建议不迁移这部分了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code
Projects
None yet
Development

No branches or pull requests

2 participants