Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Connect embed section of setting page to API #1312

Closed
jwalgran opened this issue Apr 14, 2021 · 2 comments
Closed

Connect embed section of setting page to API #1312

jwalgran opened this issue Apr 14, 2021 · 2 comments
Assignees
Labels
task 004 Enable contributors to embed a map displaying only the facilities with which they are associated in
Milestone

Comments

@jwalgran
Copy link
Contributor

jwalgran commented Apr 14, 2021

Overview

Make sure embed setting can be loaded and saved

Describe the solution you'd like

  • No redux needed
  • Fetch fields from the API in API to get non-standard fields for a contributor #1313 and incorporate them into the list of contributor fields along with a hard-coded set of standard fields
    • parent_company
    • type_of_product
    • number_of_workers
  • Fetch embed config from the EmbedConfig API and use it to populate the config fields ('width', 'height', 'color', 'font', 'contributor', 'show_other_contributor_information', 'embed_fields') and contributor fields for the configuration settings
    • The list of contributor fields should include both the fields from the nonstandard fields API and the fields from the embed config, but should not contain duplicates. Fields from the embed config take priority in case of duplicates.
  • Update/create the embed config when the user changes the config fields
  • Update the contributor embed fields when the user changes the contributor fields
@jwalgran jwalgran added the task 004 Enable contributors to embed a map displaying only the facilities with which they are associated in label Apr 14, 2021
@TaiWilkin TaiWilkin changed the title DRAFT: Connect embed section of setting page to API Connect embed section of setting page to API May 4, 2021
@TaiWilkin TaiWilkin changed the title Connect embed section of setting page to API Draft: Connect embed section of setting page to API May 4, 2021
@TaiWilkin
Copy link
Contributor

@jwalgran I expanded a bit on this for the sake of completeness. Is there any additional information you think we need here before we officially call it 'undrafted'?

@jwalgran
Copy link
Contributor Author

jwalgran commented May 5, 2021

👍 This looks good. Thanks for adding the additional detail.

@TaiWilkin TaiWilkin changed the title Draft: Connect embed section of setting page to API Connect embed section of setting page to API May 5, 2021
@TaiWilkin TaiWilkin self-assigned this May 5, 2021
@dboyer dboyer added this to the 2021 Q2 milestone Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
task 004 Enable contributors to embed a map displaying only the facilities with which they are associated in
Projects
None yet
Development

No branches or pull requests

4 participants