Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Machinery's Code Base through Refactoring #46

Closed
mauromorales opened this issue Feb 17, 2016 · 7 comments
Closed

Improve Machinery's Code Base through Refactoring #46

mauromorales opened this issue Feb 17, 2016 · 7 comments
Assignees

Comments

@mauromorales
Copy link
Member

Description: The Machinery project has been evolving in a good pace for the last couple of years by adding features and fixing bugs in an agile way. However there are places where our code base could benefit from:

  • a better design
  • more readability
  • better performance

We will achieve these goals through refactoring so we don't alter the external behavior of the code in the process of getting the benefits in our internal structure.

Deliverable: At the end of this project the student will be able to:

  • identify some code smells
  • apply a well known refactoring method
  • ensure that no regressions were introduced

Mentor: @mauromorales

Skills: Ruby, RSpec, TDD, git

Skill Level: Medium - Hard

Get started: The best way to get started is to:

@ghost
Copy link

ghost commented Mar 2, 2016

I am interested in this project. I am acquainted with Ruby, RSpec and Cucumber and have read Martin Fowler's Refactoring book. Can you please guide me in getting familiar with the codebase.

@mauromorales
Copy link
Member Author

@ajaivgeorge glad to hear you are interested :) and sure I'll be happy to shed some light.

Have you already installed and used machinery? this will be the best way to get started so you get acquainted with our terminology (i.e. scopes, inspection, description). Also keep an eye to our documentation.

Once you have some mileage with machinery make sure you can run the tests locally and understand our development toolchain.

The last step would be to dive into those tests, they will be your guide on how the machinery code is structured and our safety net to do the refactoring.

Cheers!

@ghost
Copy link

ghost commented Mar 5, 2016

Thank you. I have cloned the repo, and installed it. I will have a look at the tests and the docs and get back to you.

@mauromorales
Copy link
Member Author

@ajaivgeorge I've added a repo with some use case examples make sure you also have a look at them here

@mauromorales
Copy link
Member Author

I've also added a link to the issue with some newcomer friendly issues

@ChrisBr
Copy link
Member

ChrisBr commented Mar 22, 2016

@ajaivgeorge note that the deadline for submitting a proposal is this Friday, 25 March 19:00 UTC!

@ChrisBr
Copy link
Member

ChrisBr commented Jan 9, 2017

@mauromorales is this one still valid? If yes please open a new issue! Thanks!

@ChrisBr ChrisBr closed this as completed Jan 9, 2017
@Ana06 Ana06 added the GSoC label Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants