Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tagging when upgrading version #134

Merged
merged 2 commits into from
Oct 29, 2015
Merged

Conversation

jankowiakmaria
Copy link
Collaborator

First step of #115

@matteofigus
Copy link
Member

This is cool, I actually would like the git push with the version to be another task at this point, that just gets the version automatically?

grunt version:patch
grunt push
npm publish .

@jankowiakmaria
Copy link
Collaborator Author

Yep, makes sense - will do.

* git add .
* git commit -m "\<new version\>"
* git push
* git push --follow-tags
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matteofigus I've updated to above git command (which should:
Push all the refs that would be pushed without this option, and also push annotated tags in refs/tags that are missing from the remote but are pointing at commit-ish that are reachable from the refs being pushed) which seems to be more accurate (than pushing twice).
Don't know if it makes sense now to move it to the grunt task.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

@matteofigus
Copy link
Member

thanks 👍

matteofigus added a commit that referenced this pull request Oct 29, 2015
@matteofigus matteofigus merged commit 0d1db31 into master Oct 29, 2015
@matteofigus matteofigus deleted the AddTagWhenUpgradingVersion branch October 29, 2015 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants