Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package: Build fails when installing system-wide packages #1052

Closed
alnlarsen opened this issue Mar 14, 2023 · 1 comment · Fixed by #1241
Closed

NuGet package: Build fails when installing system-wide packages #1052

alnlarsen opened this issue Mar 14, 2023 · 1 comment · Fixed by #1241
Assignees
Labels
bug Something isn't working SDK
Milestone

Comments

@alnlarsen
Copy link
Collaborator

We have this msbuild target for verifying that an image installation succeeded:

<Target Name="VerifyInstalledPackages"
        DependsOnTargets="ProcessOpenTapPackageList"
        BeforeTargets="GenerateOpenTapReferenceProps">
  <ItemGroup>
    <PackageXmlFiles Include="@(OpenTapPackagesToInstall-> '$(OutDir)Packages/%(Identity)/package.xml')"/>
  </ItemGroup>
  <Error Condition="'@(PackageXmlFiles)' != '' AND !Exists('@(PackageXmlFiles)')" Text="Some packages failed to install."/>
</Target>

It checks if a package.xml file exists for all the packages specified in the project. This fails for system-wide packages which are not added to the debug installation, which causes all builds to fail.

@alnlarsen alnlarsen added bug Something isn't working SDK labels Mar 14, 2023
@Denrask Denrask added this to the 9.21.0 milestone Mar 20, 2023
@alnlarsen alnlarsen modified the milestones: 9.21.0, 9.22.0 Mar 24, 2023
@alnlarsen alnlarsen self-assigned this Jul 18, 2023
@github-actions
Copy link

A fix for this is in OpenTAP version 9.22.0-beta.37+14a687f2 or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SDK
Projects
None yet
2 participants