Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The version of plugins in DMM bundle does not change when bundle is downgraded #1159

Closed
alnlarsen opened this issue Jun 21, 2023 · 5 comments · Fixed by #1478 · May be fixed by #1179 or #1408
Closed

The version of plugins in DMM bundle does not change when bundle is downgraded #1159

alnlarsen opened this issue Jun 21, 2023 · 5 comments · Fixed by #1478 · May be fixed by #1179 or #1408
Assignees
@alnlarsen
Labels
Add test Test case(s) must be created for the functionality described in this issue bug Something isn't working QA Verified
Milestone
9.24.0

Comments

@alnlarsen
Copy link
Collaborator

alnlarsen commented Jun 21, 2023 •
edited

  1. install DMM bundle v2.1.0
  2. Downgrade DMM bundle to 2.0.3

Prior to 9.19, this would downgrade all the members of DMM, but now the image fails to install:

Could not resolve DMM v2.0.3
Image configuration:
  DMM: 2.0.3
  DMM API: ^2.1.3+26062d00
  DMM Instruments: ^2.1.3+26062d00
  DMM Test Steps: ^2.1.3+26062d00
  OpenTAP: ^9.23.2-beta.5+40fdd208
@alnlarsen alnlarsen added the bug Something isn't working label Jun 21, 2023
@alnlarsen alnlarsen added this to the 9.22.0 milestone Jun 21, 2023
@alnlarsen alnlarsen self-assigned this Jul 18, 2023
alnlarsen added a commit that referenced this issue Jul 18, 2023
@alnlarsen
Fix error preventing bundle downgrades. Closes #1159
f3388b8
@alnlarsen alnlarsen mentioned this issue Jul 18, 2023
Open
@Denrask
Copy link
Collaborator

Denrask commented Sep 11, 2023

We decide to push this to 9.23, as the consequences can introduce many new bugs in edge cases. This needs to be thought of really thoroughly.

@Denrask Denrask modified the milestones: 9.22.0, 9.23.0 Sep 11, 2023
@AsgerIversen AsgerIversen modified the milestones: 9.23.0, 9.24.0 Nov 27, 2023
@rmadsen-ks rmadsen-ks modified the milestones: 9.24.0, 9.23.1 Jan 12, 2024
@alnlarsen alnlarsen modified the milestones: 9.23.1, 9.23.2 Jan 22, 2024
alnlarsen added a commit that referenced this issue Jan 30, 2024
@alnlarsen
1159 relax constraints when installing bundles
8f407f2 
I think this is the right approach, but there are still a couple of issues:

1. If a bundle is installed like "tap image install 'DMM:2.1.2,DMM API:2.1.3'", the DMM API request is ignored. The image should fail to resolve, but will instead resolve to something the user did not ask for
2. If a bundle has a dependency on OpenTAP, the current OpenTAP installation might be downgraded, even if `--merge` is specified
3. If a new bundle member is added, downgrading to an older version will uninstall the new bundle member

These are a couple of strange behaviors I can think of off the top of my head. We should resolve these issues before merging this

Closes #1159
@alnlarsen alnlarsen mentioned this issue Jan 30, 2024
Draft
@alnlarsen
Copy link
Collaborator Author

I think we are closing in on a solution to this, but to avoid risk of regressions, I will move this to 9.24.

@alnlarsen alnlarsen modified the milestones: 9.23.2, 9.24.0 Jan 30, 2024
@rmadsen-ks
Copy link
Collaborator

Maybe instead of the old behavior we should add a message to manually remove the current bundle and then install the new onel.

There is a question about what to do with the installed dependencies. When uninstalling a bundle it should ask which of the dependencies also to remove. Once that is resolved the other version can be installed.

alnlarsen added a commit that referenced this issue Mar 20, 2024
@alnlarsen
Hint how to resolve bundle downgrade scenarios
e13878d 
This adds a specific error message when attempting to downgrade a bundle

Closes #1159
@alnlarsen alnlarsen mentioned this issue Mar 20, 2024
Merged
@rmadsen-ks rmadsen-ks added the Add test Test case(s) must be created for the functionality described in this issue label Mar 20, 2024
rmadsen-ks pushed a commit that referenced this issue Mar 20, 2024
@alnlarsen
Hint how to resolve bundle downgrade scenarios (#1478)
2ac2395 
This adds a specific error message when attempting to downgrade a bundle

Closes #1159
@github-actions GitHub Actions
Copy link

A fix for this is in OpenTAP version 9.24.0-beta.24+2ac23953 or later.

@bogdan-achim
Copy link
Collaborator

Verified in OpenTAP v9.24.0-beta.33

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alnlarsen alnlarsen

Labels
Add test Test case(s) must be created for the functionality described in this issue bug Something isn't working QA Verified
Projects
None yet
Milestone
9.24.0
5 participants
@Denrask @AsgerIversen @rmadsen-ks @alnlarsen @bogdan-achim