Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK plugin install should fail silently if .NET SDK is not installed #1309

Closed
sebastian-pop opened this issue Oct 16, 2023 · 1 comment · Fixed by #1310
Closed

SDK plugin install should fail silently if .NET SDK is not installed #1309

sebastian-pop opened this issue Oct 16, 2023 · 1 comment · Fixed by #1310
Labels
bug Something isn't working
Milestone
9.22.0

Comments

@sebastian-pop
Copy link
Collaborator

Describe the bug

A clear and concise description of what the bug is.

Environment (please complete the following information):

  • OS: Windows 10
  • OpenTAP Version 9.22.0-rc.2

To Reproduce

Steps to reproduce the behavior:

  1. Have OpenTAP 9.22.x installed

  2. Install the latest SDK tap package install SDK --version 9.22

Actual behavior

SDK installation fails due to not having .NET SDK installed

image

Expected behavior

SDK package should still be installed on a machine without .NET SDK installed

But it should fail silently the template installation
@sebastian-pop sebastian-pop added the bug Something isn't working label Oct 16, 2023
@alnlarsen alnlarsen mentioned this issue Oct 16, 2023
Merged
@github-actions
Copy link

A fix for this is in OpenTAP version 9.22.1-beta.6+499b5926 or later.

@rmadsen-ks rmadsen-ks added this to the 9.22.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
9.22.0
Development

Successfully merging a pull request may close this issue.

Allow the exit code dotnet runtime gives if dotnet sdk is not installed opentap/opentap
2 participants
@rmadsen-ks @sebastian-pop