Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect file reference #1370

Closed
Marc-vd-Klooster opened this issue Jan 2, 2024 · 2 comments · Fixed by #1374
Closed

Incorrect file reference #1370

Marc-vd-Klooster opened this issue Jan 2, 2024 · 2 comments · Fixed by #1374
Assignees
@rmadsen-ks
Labels
DOC: Example
Milestone
9.23.1

Comments

@Marc-vd-Klooster
Copy link

There is a incorrect file reference in the example for CustomBenchSettings.
It references to ' AccessingComponentSettings.cs' at line 23, but that file is renamed to 'SettingsRetrieval.cs'.

https://github.com/opentap/opentap/blob/3338a1acd368c6fc978884f114cf3a4c2e4d7583/sdk/Examples/PluginDevelopment/GUI/CustomBenchSettings.cs#L23C29-L23C29
@rmadsen-ks rmadsen-ks mentioned this issue Jan 4, 2024
Merged
@rmadsen-ks rmadsen-ks added this to the 9.24.0 milestone Jan 4, 2024
@rmadsen-ks
Copy link
Collaborator

Hi @Marc-vd-Klooster,

Thanks for highlighting this. I have added a fix for 9.24.0.

@rmadsen-ks rmadsen-ks self-assigned this Jan 4, 2024
@github-actions GitHub Actions
Copy link

A fix for this is in OpenTAP version 9.23.0-beta.12+2f7bf663 or later.

@alnlarsen alnlarsen modified the milestones: 9.24.0, 9.23.1 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmadsen-ks rmadsen-ks

Labels
DOC: Example
Projects
None yet
Milestone
9.23.1
Development

Successfully merging a pull request may close this issue.

1370 Fixed comment in CustomBenchSettings.cs opentap/opentap
3 participants
@rmadsen-ks @alnlarsen @Marc-vd-Klooster