Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If verdict step should not be allowed to bind to it's parent #209

Closed
AsgerIversen opened this issue Jan 24, 2022 · 2 comments · Fixed by #526
Closed

If verdict step should not be allowed to bind to it's parent #209

AsgerIversen opened this issue Jan 24, 2022 · 2 comments · Fixed by #526
Assignees
Milestone

Comments

@AsgerIversen
Copy link
Collaborator

Originally filed January 12 2022 by Mikko Ala-Kojola on GitLab

Environment:
OpenTAP 9.16.2

Steps to reproduce:

  1. Add Parallel step into a plan
  2. Add If verdict step as Parallel steps child
  3. Set Parallel steps verdict into if verdict steps If parameter
  4. Run the plan

Actual result:
Dead lock is produced.

Expected result:
If verdict should not allow verdict of it's own parent be placed as If parameter value. OpenTAP should not let to proceed into step 4.

Other remarks:
I raising this issue on behalf of colleague Teemu Luukkonen.
I used Parallel step as an example here as it's verdict is allowed in If verdicts If parameter. Not all OpenTAP test steps do.
But wanting to extend the limitation to all parents. Parent is not finished until all of it's childs are finished.

@witold wanted to be tagged into this. So that is now covered.

@github-actions
Copy link

github-actions bot commented May 5, 2022

A fix for this is in OpenTAP version 9.18.0-beta.7+ac7c6565 or later.

@tiberiumuntean21
Copy link

Fixed in OpenTAP 9.18.0-beta.7
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants