This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
Af 146 configargparse #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
==========================================
- Coverage 26.19% 24.49% -1.71%
==========================================
Files 33 35 +2
Lines 5410 5255 -155
==========================================
- Hits 1417 1287 -130
+ Misses 3993 3968 -25
Continue to review full report at Codecov.
|
mkarmona
reviewed
Jan 24, 2019
| --input-file $(JSON_PATH)/slapenrich.json.gz \ | ||
| --input-file $(JSON_PATH)/uniprot.json.gz \ | ||
| $(ES_PREFIX) 2>&1 | tee $(LOG_PATH)/out.$(ES_PREFIX).val.log | ||
| $(MRTARGET_CMD) --val 2>&1 | tee $(LOG_PATH)/out.val.log |
There was a problem hiding this comment.
wow so clean now! @afaulconbridge
mkarmona
reviewed
Jan 24, 2019
|
|
||
| def main(): | ||
| #parse config file, environment, and command line arguments | ||
| mrtarget.cfg.setup_ops_parser() | ||
| args = mrtarget.cfg.get_ops_args() |
There was a problem hiding this comment.
@afaulconbridge quite neat!
mkarmona
approved these changes
Jan 24, 2019
This was referenced Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves 90% of opentargets/issues#146
This is attempt two to merge this branch. Now config is split over two files - an ops config and a data config.
Some work still to do, but better to get this merged into master well ahead of 19.02 code freeze even if there are a few rough bits to be ironed out later. Tested locally to work end-to-end.
Note, please don't use git hub automerge from master to update this branch. It doesn't seem to handle some of the changes well.