New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mapping between drug warning and MedDRA #3003
Remove mapping between drug warning and MedDRA #3003
Comments
@jdhayhurst , @ireneisdoomed is going to be around for the next two weeks, would you mind checking with her whether this is issue is still relevant? |
@ireneisdoomed just checking with you that this is still required? It looks like if we remove the meddra LUT step, we're effectively reading in the chembl drug warning data (which comes from the chembl elastic), renaming the fields and then writing it out without any transformations. Just wanted to check that that sounds correct. |
@ireneisdoomed I removed the meddra LUT step here - this removes the meddraSocCode from the drugWarning data. I have also removed the meddraSocCode from drugWarning data model in the API and was about to make the PR when I noticed that you actually said that the meddraCode field should be removed from drug.adverseEvents. This field comes from somewhere else entirely so I wanted to be sure it's right one 😅 . The meddraCode field comes from the OpenFDA step in the ETL. The meddraCode field is ultimately derived from these sources. Please could you confirm that you'd like this |
@jdhayhurst Thank you for the changes in opentargets/platform-etl-backend#323 |
Keeping this open (the pr's auto closed it) so we can test in dev platform 😉 |
These changes have implications in the FE that we have to action to close the issue.
Thank you! |
Remove look up table between adverse effect and MedDRA code in the ETL step that processes drug warnings (and other downstream tasks).
Background
Now that we have most of the drug warnings mapped to an EFO code, the MedDRA codes we have linked to the toxicity classes are of less value.
I suggest removing this specific piece of code from the ETL as it has lost its usefulness over time. The associated dependency is costly to maintain while providing little return.
For example, the data has changed in the latest ChEMBL release (toxicity classes are now lower cased), therefore the MedDRA codes are always null (#3002)
Tasks
meddraSocCode
from thedrug.drugWarnings
API endpointMedDRA SOC Code
table from the UIAcceptance tests
How do we know the task is complete?
drugWarnings
dataset does not have a field called `meddraSocCode``drug.drugWarnings.meddraSocCode
no longer existsThe text was updated successfully, but these errors were encountered: