Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display more details for drug mode of action in drug tables #730

Closed
MichaelaEBI opened this issue Sep 10, 2019 · 5 comments
Closed

Display more details for drug mode of action in drug tables #730

MichaelaEBI opened this issue Sep 10, 2019 · 5 comments
Assignees

Comments

@MichaelaEBI
Copy link

Based on ticket #533 there are two front end changes related to drug mechanism of action:

  1. ChEMBL have changed the values of the target.activity field to be negative_modulator, positive_modulator and other. In the Open Targets front end we currently do this:
 // 11: Activity
                        cell = item.target.activity;
                        switch (cell) {
                        case 'drug_positive_modulator' :
                            cell = 'agonist';
                            break;
                        case 'drug_negative_modulator' :
                            cell = 'antagonist';
                            break;
                        }

The new values can be displayed in the drugs table and do not have to be mapped to agonist, antagonist anymore.

2.) ChEMBL provides more detailed mechanism of action terms in the target2drug.action_type field. This field gives more details which would be useful to users. It would be great to display this field together with .target.activity.

@andrewhercules
Copy link
Contributor

This has been pushed to the 19.11 release - please see the 19.11 Release Intentions document for more information.

LucaFumis added a commit to opentargets-archive/webapp that referenced this issue Sep 23, 2019
@LucaFumis
Copy link

Part 1 (activity label) has been completed and included in 19.09.
Only part 2 is left for 19.11 release.

LucaFumis added a commit to opentargets-archive/webapp that referenced this issue Oct 11, 2019
@LucaFumis
Copy link

LucaFumis commented Oct 16, 2019

I've updated qa and the drugs table now shows an "action type" column: have a look at some point and let me know if the location (column order) makes sense.

@d0choa
Copy link
Contributor

d0choa commented Oct 17, 2019

Column order looks good to me. I'll leave it to @andrewhercules (or @MichaelaEBI feedback) to decide whether this can be closed.

@andrewhercules
Copy link
Contributor

Ticket closed as work has been completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants