Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes: On update, should attribute values be able to have all properties changed? #63

Closed
jrschumacher opened this issue Jan 23, 2024 · 3 comments
Closed

Attributes: On update, should attribute values be able to have all properties changed? #63

jrschumacher opened this issue Jan 23, 2024 · 3 comments
Labels
comp:architecture Anything that impacts architecture help wanted Extra attention is needed question Further information is requested

Comments

@jrschumacher
Copy link
Member

During the update process, should attribute values be able to have all properties changed?

  • What happens if an attribute value is moved to a new attribute?
    • USA moved from relto to rels
  • What happens if an attribute value is changed from US to USA?
@jrschumacher jrschumacher added question Further information is requested help wanted Extra attention is needed labels Jan 23, 2024
@jrschumacher
Copy link
Member Author

Based on feedback from @cassandrabailey293 and @biscoe916

mutable

  • value name
  • members

muck with db

  • attribute id

@jrschumacher jrschumacher mentioned this issue Jan 23, 2024
Closed
@jrschumacher jrschumacher added the comp:architecture Anything that impacts architecture label Jan 24, 2024
@jakedoublev
Copy link
Contributor

jakedoublev commented Jan 26, 2024 •
edited

The top-level attribute definition's namespace_id is explicitly prevented from being updated (with integration tests covering the behavior) in #99

@jakedoublev jakedoublev mentioned this issue Jan 31, 2024
Closed
@jrschumacher
Copy link
Member Author

This will be resolved with #96 and #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:architecture Anything that impacts architecture help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrschumacher @jakedoublev