Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ers): Create entity resolution service, replace idp plugin #660

Merged
merged 24 commits into from
May 7, 2024
Merged

feat(ers): Create entity resolution service, replace idp plugin #660

merged 24 commits into from
May 7, 2024

Conversation

elizabethhealy
Copy link
Member

@elizabethhealy elizabethhealy commented Apr 24, 2024 •
edited

#567

Define entity resolution service interface (ERS)
Move Keycloak IDP Plugin to a service implementing the ERS contract
Update the rego to fetch the entity representation for a configured ERS endpoint
Remove Keycloak specific inputs in OPA engine call.

@elizabethhealy elizabethhealy marked this pull request as ready for review April 25, 2024 19:57
@elizabethhealy elizabethhealy requested review from a team as code owners April 25, 2024 19:57
ttschampel
ttschampel reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@ttschampel ttschampel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove entitlements.rego and rename entitlements-keycloak.rego to entitlements.rego since it is now generic?

strantalis
strantalis reviewed May 1, 2024
View reviewed changes
opentdf-dev.yaml Show resolved Hide resolved
service/entityresolution/entity_resolution.proto Outdated Show resolved Hide resolved
@elizabethhealy elizabethhealy added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit ff44112 May 7, 2024
16 checks passed
@elizabethhealy elizabethhealy deleted the move-idpplugin-to-ers branch May 7, 2024 13:53
This was referenced May 7, 2024
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 7, 2024
@opentdf-automation
chore(main): release service 0.4.1 (#728)
6208a1f 
🤖 I have created a release *beep* *boop*
---


##
[0.4.1](service/v0.4.0...service/v0.4.1)
(2024-05-07)


### Features

* **core:** cors config
([#746](#746))
([3433b5b](3433b5b))
* **core:** Service Level Child Loggers
([#740](#740))
([aa0f210](aa0f210))
* **ers:** Create entity resolution service, replace idp plugin
([#660](#660))
([ff44112](ff44112))
* **sdk:** insecure plaintext and skip verify conn
([#670](#670))
([5c94d02](5c94d02))


### Bug Fixes

* **core:** Fix Lint
([#714](#714))
([2b0cb09](2b0cb09)),
closes [#701](#701)
* **core:** Fix several misspellings
([#738](#738))
([8d61db3](8d61db3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request May 7, 2024
@opentdf-automation
chore(main): release protocol/go 0.2.1 (#692)
4db49f1 
🤖 I have created a release *beep* *boop*
---


##
[0.2.1](protocol/go/v0.2.0...protocol/go/v0.2.1)
(2024-05-07)


### Features

* **ers:** Create entity resolution service, replace idp plugin
([#660](#660))
([ff44112](ff44112))


### Bug Fixes

* **policy:** normalize FQN lookup to lower case
([#668](#668))
([cd8a875](cd8a875)),
closes [#669](#669)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request May 7, 2024
@opentdf-automation
chore(main): release lib/fixtures 0.2.1 (#685)
b02c502 
🤖 I have created a release *beep* *boop*
---


##
[0.2.1](lib/fixtures/v0.2.0...lib/fixtures/v0.2.1)
(2024-05-07)


### Features

* **ers:** Create entity resolution service, replace idp plugin
([#660](#660))
([ff44112](ff44112))
* **sdk:** Adds TLS Certificate Exchange Flow
([#667](#667))
([0e59213](0e59213))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
tech-guru42 added a commit to tech-guru42/TDF that referenced this pull request Jun 3, 2024
@tech-guru42 @opentdf-automation
chore(main): release service 0.4.1 (#728)
f7026de 
🤖 I have created a release *beep* *boop*
---


##
[0.4.1](opentdf/platform@service/v0.4.0...service/v0.4.1)
(2024-05-07)


### Features

* **core:** cors config
([#746](opentdf/platform#746))
([3433b5b](opentdf/platform@3433b5b))
* **core:** Service Level Child Loggers
([#740](opentdf/platform#740))
([aa0f210](opentdf/platform@aa0f210))
* **ers:** Create entity resolution service, replace idp plugin
([#660](opentdf/platform#660))
([ff44112](opentdf/platform@ff44112))
* **sdk:** insecure plaintext and skip verify conn
([#670](opentdf/platform#670))
([5c94d02](opentdf/platform@5c94d02))


### Bug Fixes

* **core:** Fix Lint
([#714](opentdf/platform#714))
([2b0cb09](opentdf/platform@2b0cb09)),
closes [#701](opentdf/platform#701)
* **core:** Fix several misspellings
([#738](opentdf/platform#738))
([8d61db3](opentdf/platform@8d61db3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
tech-guru42 added a commit to tech-guru42/TDF that referenced this pull request Jun 3, 2024
@tech-guru42 @opentdf-automation
chore(main): release protocol/go 0.2.1 (#692)
8ea51cf 
🤖 I have created a release *beep* *boop*
---


##
[0.2.1](opentdf/platform@protocol/go/v0.2.0...protocol/go/v0.2.1)
(2024-05-07)


### Features

* **ers:** Create entity resolution service, replace idp plugin
([#660](opentdf/platform#660))
([ff44112](opentdf/platform@ff44112))


### Bug Fixes

* **policy:** normalize FQN lookup to lower case
([#668](opentdf/platform#668))
([cd8a875](opentdf/platform@cd8a875)),
closes [#669](opentdf/platform#669)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
tech-guru42 added a commit to tech-guru42/TDF that referenced this pull request Jun 3, 2024
@tech-guru42 @opentdf-automation
chore(main): release lib/fixtures 0.2.1 (#685)
962e91a 
🤖 I have created a release *beep* *boop*
---


##
[0.2.1](opentdf/platform@lib/fixtures/v0.2.0...lib/fixtures/v0.2.1)
(2024-05-07)


### Features

* **ers:** Create entity resolution service, replace idp plugin
([#660](opentdf/platform#660))
([ff44112](opentdf/platform@ff44112))
* **sdk:** Adds TLS Certificate Exchange Flow
([#667](opentdf/platform#667))
([0e59213](opentdf/platform@0e59213))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127 added a commit to passion-127/TDF that referenced this pull request Jun 6, 2024
@passion-127 @opentdf-automation
chore(main): release service 0.4.1 (#728)
68eb4f9 
🤖 I have created a release *beep* *boop*
---


##
[0.4.1](opentdf/platform@service/v0.4.0...service/v0.4.1)
(2024-05-07)


### Features

* **core:** cors config
([#746](opentdf/platform#746))
([3433b5b](opentdf/platform@3433b5b))
* **core:** Service Level Child Loggers
([#740](opentdf/platform#740))
([aa0f210](opentdf/platform@aa0f210))
* **ers:** Create entity resolution service, replace idp plugin
([#660](opentdf/platform#660))
([ff44112](opentdf/platform@ff44112))
* **sdk:** insecure plaintext and skip verify conn
([#670](opentdf/platform#670))
([5c94d02](opentdf/platform@5c94d02))


### Bug Fixes

* **core:** Fix Lint
([#714](opentdf/platform#714))
([2b0cb09](opentdf/platform@2b0cb09)),
closes [#701](opentdf/platform#701)
* **core:** Fix several misspellings
([#738](opentdf/platform#738))
([8d61db3](opentdf/platform@8d61db3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127 added a commit to passion-127/TDF that referenced this pull request Jun 6, 2024
@passion-127 @opentdf-automation
chore(main): release protocol/go 0.2.1 (#692)
ca3e09c 
🤖 I have created a release *beep* *boop*
---


##
[0.2.1](opentdf/platform@protocol/go/v0.2.0...protocol/go/v0.2.1)
(2024-05-07)


### Features

* **ers:** Create entity resolution service, replace idp plugin
([#660](opentdf/platform#660))
([ff44112](opentdf/platform@ff44112))


### Bug Fixes

* **policy:** normalize FQN lookup to lower case
([#668](opentdf/platform#668))
([cd8a875](opentdf/platform@cd8a875)),
closes [#669](opentdf/platform#669)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127 added a commit to passion-127/TDF that referenced this pull request Jun 6, 2024
@passion-127 @opentdf-automation
chore(main): release lib/fixtures 0.2.1 (#685)
d27f27e 
🤖 I have created a release *beep* *boop*
---


##
[0.2.1](opentdf/platform@lib/fixtures/v0.2.0...lib/fixtures/v0.2.1)
(2024-05-07)


### Features

* **ers:** Create entity resolution service, replace idp plugin
([#660](opentdf/platform#660))
([ff44112](opentdf/platform@ff44112))
* **sdk:** Adds TLS Certificate Exchange Flow
([#667](opentdf/platform#667))
([0e59213](opentdf/platform@0e59213))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttschampel ttschampel ttschampel left review comments

@jakedoublev jakedoublev jakedoublev left review comments

@strantalis strantalis strantalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elizabethhealy @ttschampel @strantalis @jakedoublev