Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): insecure plaintext and skip verify conn #670

Merged
merged 20 commits into from
May 1, 2024
Merged

feat(sdk): insecure plaintext and skip verify conn #670

merged 20 commits into from
May 1, 2024

Conversation

pflynn-virtru
Copy link
Member

@pflynn-virtru pflynn-virtru commented Apr 26, 2024 •
edited

resolves #631

breaking change in the SDK

// WithInsecurePlaintextConn returns an Option that sets up HTTP connection sent in the clear.
func WithInsecurePlaintextConn() Option {

// WithInsecureSkipVerifyConn returns an Option that sets up HTTPS connection without verification.
func WithInsecureSkipVerifyConn() Option {
  • Some log statement changes

@pflynn-virtru pflynn-virtru linked an issue Apr 26, 2024 that may be closed by this pull request
add WithGrpcPlainText sdk option #631
Closed
@pflynn-virtru pflynn-virtru marked this pull request as ready for review April 30, 2024 21:25
@pflynn-virtru pflynn-virtru requested review from a team as code owners April 30, 2024 21:25
@pflynn-virtru pflynn-virtru changed the title feat(sdk): insecure plaintext conn feat(sdk): insecure plaintext and skip verify conn Apr 30, 2024
mkleene
mkleene approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@mkleene mkleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! good call on propagating the TLS settings to the IDP connections.

@pflynn-virtru pflynn-virtru added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 5c94d02 May 1, 2024
16 checks passed
@pflynn-virtru pflynn-virtru deleted the 631-add-withgrpcplaintext-sdk-option branch May 1, 2024 20:00
This was referenced May 1, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 7, 2024
@opentdf-automation
chore(main): release service 0.4.1 (#728)
6208a1f 
🤖 I have created a release *beep* *boop*
---


##
[0.4.1](service/v0.4.0...service/v0.4.1)
(2024-05-07)


### Features

* **core:** cors config
([#746](#746))
([3433b5b](3433b5b))
* **core:** Service Level Child Loggers
([#740](#740))
([aa0f210](aa0f210))
* **ers:** Create entity resolution service, replace idp plugin
([#660](#660))
([ff44112](ff44112))
* **sdk:** insecure plaintext and skip verify conn
([#670](#670))
([5c94d02](5c94d02))


### Bug Fixes

* **core:** Fix Lint
([#714](#714))
([2b0cb09](2b0cb09)),
closes [#701](#701)
* **core:** Fix several misspellings
([#738](#738))
([8d61db3](8d61db3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request May 10, 2024
@opentdf-automation
chore(main): release sdk 0.2.1 (#686)
b6bcaa6 
🤖 I have created a release *beep* *boop*
---


##
[0.2.1](sdk/v0.2.0...sdk/v0.2.1)
(2024-05-10)


### Features

* **sdk:** Adds TLS Certificate Exchange Flow
([#667](#667))
([0e59213](0e59213))
* **sdk:** insecure plaintext and skip verify conn
([#670](#670))
([5c94d02](5c94d02))


### Bug Fixes

* **core:** Fix Lint
([#714](#714))
([2b0cb09](2b0cb09)),
closes [#701](#701)
* **core:** Fix several misspellings
([#738](#738))
([8d61db3](8d61db3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
@jrschumacher
Copy link
Member

In the future, use the breaking change convention

Subject feat(sdk)!: insecure plaintext and skip verify conn

Body/description:

BREAKING CHANGE:
.```
// WithInsecurePlaintextConn returns an Option that sets up HTTP connection sent in the clear.
func WithInsecurePlaintextConn() Option {

// WithInsecureSkipVerifyConn returns an Option that sets up HTTPS connection without verification.
func WithInsecureSkipVerifyConn() Option {
.```

- Some log statement changes"

tech-guru42 added a commit to tech-guru42/TDF that referenced this pull request Jun 3, 2024
@tech-guru42 @opentdf-automation
chore(main): release service 0.4.1 (#728)
f7026de 
🤖 I have created a release *beep* *boop*
---


##
[0.4.1](opentdf/platform@service/v0.4.0...service/v0.4.1)
(2024-05-07)


### Features

* **core:** cors config
([#746](opentdf/platform#746))
([3433b5b](opentdf/platform@3433b5b))
* **core:** Service Level Child Loggers
([#740](opentdf/platform#740))
([aa0f210](opentdf/platform@aa0f210))
* **ers:** Create entity resolution service, replace idp plugin
([#660](opentdf/platform#660))
([ff44112](opentdf/platform@ff44112))
* **sdk:** insecure plaintext and skip verify conn
([#670](opentdf/platform#670))
([5c94d02](opentdf/platform@5c94d02))


### Bug Fixes

* **core:** Fix Lint
([#714](opentdf/platform#714))
([2b0cb09](opentdf/platform@2b0cb09)),
closes [#701](opentdf/platform#701)
* **core:** Fix several misspellings
([#738](opentdf/platform#738))
([8d61db3](opentdf/platform@8d61db3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
tech-guru42 added a commit to tech-guru42/TDF that referenced this pull request Jun 3, 2024
@tech-guru42 @opentdf-automation
chore(main): release sdk 0.2.1 (#686)
9e1b41b 
🤖 I have created a release *beep* *boop*
---


##
[0.2.1](opentdf/platform@sdk/v0.2.0...sdk/v0.2.1)
(2024-05-10)


### Features

* **sdk:** Adds TLS Certificate Exchange Flow
([#667](opentdf/platform#667))
([0e59213](opentdf/platform@0e59213))
* **sdk:** insecure plaintext and skip verify conn
([#670](opentdf/platform#670))
([5c94d02](opentdf/platform@5c94d02))


### Bug Fixes

* **core:** Fix Lint
([#714](opentdf/platform#714))
([2b0cb09](opentdf/platform@2b0cb09)),
closes [#701](opentdf/platform#701)
* **core:** Fix several misspellings
([#738](opentdf/platform#738))
([8d61db3](opentdf/platform@8d61db3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127 added a commit to passion-127/TDF that referenced this pull request Jun 6, 2024
@passion-127 @opentdf-automation
chore(main): release service 0.4.1 (#728)
68eb4f9 
🤖 I have created a release *beep* *boop*
---


##
[0.4.1](opentdf/platform@service/v0.4.0...service/v0.4.1)
(2024-05-07)


### Features

* **core:** cors config
([#746](opentdf/platform#746))
([3433b5b](opentdf/platform@3433b5b))
* **core:** Service Level Child Loggers
([#740](opentdf/platform#740))
([aa0f210](opentdf/platform@aa0f210))
* **ers:** Create entity resolution service, replace idp plugin
([#660](opentdf/platform#660))
([ff44112](opentdf/platform@ff44112))
* **sdk:** insecure plaintext and skip verify conn
([#670](opentdf/platform#670))
([5c94d02](opentdf/platform@5c94d02))


### Bug Fixes

* **core:** Fix Lint
([#714](opentdf/platform#714))
([2b0cb09](opentdf/platform@2b0cb09)),
closes [#701](opentdf/platform#701)
* **core:** Fix several misspellings
([#738](opentdf/platform#738))
([8d61db3](opentdf/platform@8d61db3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127 added a commit to passion-127/TDF that referenced this pull request Jun 6, 2024
@passion-127 @opentdf-automation
chore(main): release sdk 0.2.1 (#686)
33f278c 
🤖 I have created a release *beep* *boop*
---


##
[0.2.1](opentdf/platform@sdk/v0.2.0...sdk/v0.2.1)
(2024-05-10)


### Features

* **sdk:** Adds TLS Certificate Exchange Flow
([#667](opentdf/platform#667))
([0e59213](opentdf/platform@0e59213))
* **sdk:** insecure plaintext and skip verify conn
([#670](opentdf/platform#670))
([5c94d02](opentdf/platform@5c94d02))


### Bug Fixes

* **core:** Fix Lint
([#714](opentdf/platform#714))
([2b0cb09](opentdf/platform@2b0cb09)),
closes [#701](opentdf/platform#701)
* **core:** Fix several misspellings
([#738](opentdf/platform#738))
([8d61db3](opentdf/platform@8d61db3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkleene mkleene mkleene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add WithGrpcPlainText sdk option
3 participants
@pflynn-virtru @jrschumacher @mkleene