-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Fix several misspellings #738
Conversation
This is a great idea! We already use golangci-lint which has the ability to add misspell to check for spelling errors. I'd prefer to minimize the number of external tools if we can. Would you give this a try to see how it compares? Also I'm not sure we want to introduce precommits as this will need to be a more detailed conversation. Precommits are great for small teams but large opensource projects they can become burdensome and many projects lean on CI linters. |
I've undone the addition of pre-commit. Sorry about that, I saw @jrschumacher 's comments before I pushed, and then saw @dmihalcik-virtru 's comments . I did ask about this before I pushed, but didn't hear back earlier (see #736 🙊 🦗 ) My highest priority is to use the platform (work which has a deadline), so I'll let you all determine the best path forward in automation/linting. For now, this PR just fixes the existing spelling errors. |
🤖 I have created a release *beep* *boop* --- ## [0.4.1](service/v0.4.0...service/v0.4.1) (2024-05-07) ### Features * **core:** cors config ([#746](#746)) ([3433b5b](3433b5b)) * **core:** Service Level Child Loggers ([#740](#740)) ([aa0f210](aa0f210)) * **ers:** Create entity resolution service, replace idp plugin ([#660](#660)) ([ff44112](ff44112)) * **sdk:** insecure plaintext and skip verify conn ([#670](#670)) ([5c94d02](5c94d02)) ### Bug Fixes * **core:** Fix Lint ([#714](#714)) ([2b0cb09](2b0cb09)), closes [#701](#701) * **core:** Fix several misspellings ([#738](#738)) ([8d61db3](8d61db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.2.1](sdk/v0.2.0...sdk/v0.2.1) (2024-05-10) ### Features * **sdk:** Adds TLS Certificate Exchange Flow ([#667](#667)) ([0e59213](0e59213)) * **sdk:** insecure plaintext and skip verify conn ([#670](#670)) ([5c94d02](5c94d02)) ### Bug Fixes * **core:** Fix Lint ([#714](#714)) ([2b0cb09](2b0cb09)), closes [#701](#701) * **core:** Fix several misspellings ([#738](#738)) ([8d61db3](8d61db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.4.1](opentdf/platform@service/v0.4.0...service/v0.4.1) (2024-05-07) ### Features * **core:** cors config ([#746](opentdf/platform#746)) ([3433b5b](opentdf/platform@3433b5b)) * **core:** Service Level Child Loggers ([#740](opentdf/platform#740)) ([aa0f210](opentdf/platform@aa0f210)) * **ers:** Create entity resolution service, replace idp plugin ([#660](opentdf/platform#660)) ([ff44112](opentdf/platform@ff44112)) * **sdk:** insecure plaintext and skip verify conn ([#670](opentdf/platform#670)) ([5c94d02](opentdf/platform@5c94d02)) ### Bug Fixes * **core:** Fix Lint ([#714](opentdf/platform#714)) ([2b0cb09](opentdf/platform@2b0cb09)), closes [#701](opentdf/platform#701) * **core:** Fix several misspellings ([#738](opentdf/platform#738)) ([8d61db3](opentdf/platform@8d61db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.2.1](opentdf/platform@sdk/v0.2.0...sdk/v0.2.1) (2024-05-10) ### Features * **sdk:** Adds TLS Certificate Exchange Flow ([#667](opentdf/platform#667)) ([0e59213](opentdf/platform@0e59213)) * **sdk:** insecure plaintext and skip verify conn ([#670](opentdf/platform#670)) ([5c94d02](opentdf/platform@5c94d02)) ### Bug Fixes * **core:** Fix Lint ([#714](opentdf/platform#714)) ([2b0cb09](opentdf/platform@2b0cb09)), closes [#701](opentdf/platform#701) * **core:** Fix several misspellings ([#738](opentdf/platform#738)) ([8d61db3](opentdf/platform@8d61db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.4.1](opentdf/platform@service/v0.4.0...service/v0.4.1) (2024-05-07) ### Features * **core:** cors config ([#746](opentdf/platform#746)) ([3433b5b](opentdf/platform@3433b5b)) * **core:** Service Level Child Loggers ([#740](opentdf/platform#740)) ([aa0f210](opentdf/platform@aa0f210)) * **ers:** Create entity resolution service, replace idp plugin ([#660](opentdf/platform#660)) ([ff44112](opentdf/platform@ff44112)) * **sdk:** insecure plaintext and skip verify conn ([#670](opentdf/platform#670)) ([5c94d02](opentdf/platform@5c94d02)) ### Bug Fixes * **core:** Fix Lint ([#714](opentdf/platform#714)) ([2b0cb09](opentdf/platform@2b0cb09)), closes [#701](opentdf/platform#701) * **core:** Fix several misspellings ([#738](opentdf/platform#738)) ([8d61db3](opentdf/platform@8d61db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.2.1](opentdf/platform@sdk/v0.2.0...sdk/v0.2.1) (2024-05-10) ### Features * **sdk:** Adds TLS Certificate Exchange Flow ([#667](opentdf/platform#667)) ([0e59213](opentdf/platform@0e59213)) * **sdk:** insecure plaintext and skip verify conn ([#670](opentdf/platform#670)) ([5c94d02](opentdf/platform@5c94d02)) ### Bug Fixes * **core:** Fix Lint ([#714](opentdf/platform#714)) ([2b0cb09](opentdf/platform@2b0cb09)), closes [#701](opentdf/platform#701) * **core:** Fix several misspellings ([#738](opentdf/platform#738)) ([8d61db3](opentdf/platform@8d61db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
This PR fixes several misspellings.
Since doing this work manually seems like a waste of time, you might consider introducing automation to prevent spelling errors (I make them constantly).
One automatic spell-checker is https://github.com/codespell-project/codespell . It's very easy to run both locally and in CI, using pre-commit, e.g. the following will lint Go, Markdown, and YAML: