fix(core): wrong AuthorizationService provided with missing logger #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imdominicreed
changed the title
strantalis
approved these changes
May 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.2](service/v0.4.1...service/v0.4.2) (2024-05-15) ### Features * **docs:** improve serviceregistry doc annotations ([#799](#799)) ([df8a504](df8a504)) ### Bug Fixes * **authz:** Adds jwt to context when verified ([#764](#764)) ([7bf6513](7bf6513)) * **ci:** Use the correct schema with the provision fixture command ([#794](#794)) ([459e82a](459e82a)) * **core:** Bump dep on sdk; reduce go to 1.21 ([#815](#815)) ([fe4a5ca](fe4a5ca)) * **core:** rollup readiness checks to central health service ([#755](#755)) ([8a65161](8a65161)), closes [#726](#726) * **core:** Updates logs statements to log errors ([#796](#796)) ([7a3379b](7a3379b)) * **core:** wrong AuthorizationService provided with missing logger ([#791](#791)) ([b13be04](b13be04)) * **sdk:** Reduces sdk go requirement to 1.21 ([#795](#795)) ([6baee80](6baee80)) * **service:** cleanup the cryptoprovider config ([#803](#803)) ([1458d17](1458d17)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
tech-guru42
added a commit
to tech-guru42/TDF
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.2](opentdf/platform@service/v0.4.1...service/v0.4.2) (2024-05-15) ### Features * **docs:** improve serviceregistry doc annotations ([#799](opentdf/platform#799)) ([df8a504](opentdf/platform@df8a504)) ### Bug Fixes * **authz:** Adds jwt to context when verified ([#764](opentdf/platform#764)) ([7bf6513](opentdf/platform@7bf6513)) * **ci:** Use the correct schema with the provision fixture command ([#794](opentdf/platform#794)) ([459e82a](opentdf/platform@459e82a)) * **core:** Bump dep on sdk; reduce go to 1.21 ([#815](opentdf/platform#815)) ([fe4a5ca](opentdf/platform@fe4a5ca)) * **core:** rollup readiness checks to central health service ([#755](opentdf/platform#755)) ([8a65161](opentdf/platform@8a65161)), closes [#726](opentdf/platform#726) * **core:** Updates logs statements to log errors ([#796](opentdf/platform#796)) ([7a3379b](opentdf/platform@7a3379b)) * **core:** wrong AuthorizationService provided with missing logger ([#791](opentdf/platform#791)) ([b13be04](opentdf/platform@b13be04)) * **sdk:** Reduces sdk go requirement to 1.21 ([#795](opentdf/platform#795)) ([6baee80](opentdf/platform@6baee80)) * **service:** cleanup the cryptoprovider config ([#803](opentdf/platform#803)) ([1458d17](opentdf/platform@1458d17)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127
added a commit
to passion-127/TDF
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.2](opentdf/platform@service/v0.4.1...service/v0.4.2) (2024-05-15) ### Features * **docs:** improve serviceregistry doc annotations ([#799](opentdf/platform#799)) ([df8a504](opentdf/platform@df8a504)) ### Bug Fixes * **authz:** Adds jwt to context when verified ([#764](opentdf/platform#764)) ([7bf6513](opentdf/platform@7bf6513)) * **ci:** Use the correct schema with the provision fixture command ([#794](opentdf/platform#794)) ([459e82a](opentdf/platform@459e82a)) * **core:** Bump dep on sdk; reduce go to 1.21 ([#815](opentdf/platform#815)) ([fe4a5ca](opentdf/platform@fe4a5ca)) * **core:** rollup readiness checks to central health service ([#755](opentdf/platform#755)) ([8a65161](opentdf/platform@8a65161)), closes [#726](opentdf/platform#726) * **core:** Updates logs statements to log errors ([#796](opentdf/platform#796)) ([7a3379b](opentdf/platform@7a3379b)) * **core:** wrong AuthorizationService provided with missing logger ([#791](opentdf/platform#791)) ([b13be04](opentdf/platform@b13be04)) * **sdk:** Reduces sdk go requirement to 1.21 ([#795](opentdf/platform#795)) ([6baee80](opentdf/platform@6baee80)) * **service:** cleanup the cryptoprovider config ([#803](opentdf/platform#803)) ([1458d17](opentdf/platform@1458d17)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthorizationService had no tokenSource or logger causing panics from nil pointer exceptions.
This PR returns the correct AuthorizationService with a provided logger.