Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update luci-commotion requirements to include freifunk p2pblock #35

Closed
seamustuohy opened this issue Dec 2, 2013 · 5 comments
Closed
Assignees
Milestone

Comments

@seamustuohy
Copy link
Collaborator

per: opentechinstitute/luci-commotion#97

@areynold
Copy link
Collaborator

areynold commented Dec 4, 2013

Easy enough. Can this be handled as a regular pull request instead of putting it in the Usability stream? Since it will require a config update to commotion-openwrt I worry that we will end up with conflicts by the time usability gets merged.

@areynold
Copy link
Collaborator

areynold commented Dec 4, 2013

Done. See https://github.com/opentechinstitute/commotion-openwrt/tree/ff-p2pblock and https://github.com/opentechinstitute/commotion-feed/tree/ff-p2pblock.

@elationfoundation, you mentioned some settings tweaks and that @jheretic had requested additional testing. What else should be rolled into the pull request?

@westbywest
Copy link
Collaborator

The freifunk-p2pblock script, as packaged into OpenWRT, assumes the presence of an interface named 'wan' to apply all of its iptables rules to. If no active wan interface exists, e.g. on repeater nodes with the present Commotion-OpenWRT firewall, then freifunk-p2pblock will have no effect.

@glamrock
Copy link
Collaborator

glamrock commented Jan 2, 2014

Are we going to expand on the upstream freifunk-p2pblock script for v1.1?

@jheretic
Copy link
Member

The wan interface has since been added, though freifunk-p2pblock has not been added in pending further QoS work. So an external install of freifunk-p2pblock should at least function as expected, though it is as yet unsupported. I'm closing out this issue as finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants