Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispatcher errors in controller/splash.lua #23

Closed
areynold opened this issue Feb 28, 2014 · 3 comments
Closed

Dispatcher errors in controller/splash.lua #23

areynold opened this issue Feb 28, 2014 · 3 comments
Assignees
@areynold
Labels
3 - Done bug
Milestone
1.1

Comments

@areynold
Copy link
Collaborator

The following functions in Admin > Advanced > Services > Captive Portal cause a dispatcher error on submit:

  • Interface
  • Whitelist
  • Ban

All three receive an "attempt to call global 'translate' a nil value" error from line 102 of https://github.com/opentechinstitute/luci-commotion-splash/blob/master/luasrc/controller/commotion-splash/splash.lua
@areynold areynold added this to the 1.1 milestone Feb 28, 2014
@areynold
Copy link
Collaborator Author

areynold commented Mar 4, 2014

Whoever takes this issue should also fix the typo on line 120 ("automatice" should be "automatic")

@areynold areynold self-assigned this Mar 4, 2014
@areynold
Copy link
Collaborator Author

areynold commented Mar 4, 2014

Just pushed a branch (dispatcher-error) that addresses the original issue but exposes several new ones.

This was referenced Mar 5, 2014
Closed
Closed
@areynold areynold assigned areynold and unassigned areynold Mar 5, 2014
@jheretic
Copy link
Member

This has been superseded by #26 and related pull requests.

@oti-tech oti-tech mentioned this issue Jun 18, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@areynold areynold

Labels
3 - Done bug
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@areynold @jheretic