IAM: Provider resource overhaul #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 19, 2023 17:39
# Conflicts: # go.mod # go.sum
artem-lifshits
requested review from
Aloento,
vladimirvshivkov and
anton-sidelnikov
artem-lifshits
dismissed
vladimirvshivkov’s stale review
The merge-base changed after approval.
Polina-Gubina
previously approved these changes
Jul 19, 2023
vladimirvshivkov
previously approved these changes
Jul 19, 2023
artem-lifshits
dismissed stale reviews from vladimirvshivkov and Polina-Gubina
The merge-base changed after approval.
Polina-Gubina
previously approved these changes
Jul 19, 2023
artem-lifshits
dismissed
Polina-Gubina’s stale review
The merge-base changed after approval.
vladimirvshivkov
previously approved these changes
Jul 19, 2023
anton-sidelnikov
requested changes
Jul 19, 2023
| Type: schema.TypeString, | ||
| Optional: true, | ||
| }, | ||
| "access_config": { |
There was a problem hiding this comment.
conflict with metadata
| } | ||
|
|
||
| func getDefaultConversionOpts() *mappings.CreateOpts { | ||
| localRules := []mappings.LocalRuleOpts{ |
There was a problem hiding this comment.
try to make rules editable
Aloento
approved these changes
Jul 19, 2023
anton-sidelnikov
approved these changes
Jul 20, 2023
|
Build succeeded. ✔️ build-otc-releasenotes SUCCESS in 4m 26s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Implement new resource
opentelekomcloud_identity_providerto manage identity providers with SAML/OIDC supportPR Checklist
Acceptance Steps Performed