Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change github default branch to staging #1780

Open
mjurbanski-reef opened this issue Apr 10, 2024 · 1 comment
Open

Change github default branch to staging #1780

mjurbanski-reef opened this issue Apr 10, 2024 · 1 comment
Labels
feature new feature added

Comments

@mjurbanski-reef
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It is a common issue that PRs are branched from default branch (master) and then target master ( #1749 , #1750, ...) despite CONTRIB instructions saying staging branch should be used.

An that is only natural, since it is different how most github project work, and is very easy to forget about it even if you did read Contributing instruction at the some point.

Describe the solution you'd like

Change the default github branch to staging, which will make one less thing to remember for contributors and should not affect maintainers much. In fact they will also have less load on them since they will not have to correct contributors nearly as often.

IDK if people installing from source want to have bleeding-edge version or not, but if we assume they want stable then single adjustment to readme instruction has to be made after this change: git clone -b master https://github.com/opentensor/bittensor.git .

Describe alternatives you've considered

Just keep going as is, adding even more warning etc that only add cognitive load, but it seems like more confusion and work for everyone involved.

Additional context

No response

@mjurbanski-reef mjurbanski-reef added the feature new feature added label Apr 10, 2024
@rajkaramchedu
Copy link
Contributor

From docs (docs.bittensor.com) point of view, this will work. I can modify the git clone instructions as @mjurbanski-reef suggested above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature added
Projects
None yet
Development

No branches or pull requests

2 participants